Avro Schema generation: allow mapping Java Enum properties to Avro String values about jackson-dataformats-binary HOT 7 CLOSED

Would this be possible wrt Avro schema limitations? Would new type be defined as Union, allowing both String and Enum? And which direction is the change? (older schema exception String, new Enum? Or vice versa)

At JsonGenerator (and so AvroGenerator subtype) level Enums are typically written using writeString() anyway (since JSON has no "Enum" type; conversion handled at databind level).
Same for JsonParser/AvroParser.

So I am not 100% sure I yet understand the ask here.

from jackson-dataformats-binary.

I am suggesting an option where the generated avro schema for an enum field would simply be String.

This would enable extending the enum in the future, with no change in schema.

from jackson-dataformats-binary.

@jlous Ah ok. Depending on how implemented it might even be a general MapperFeature; I forget what the division is between model traversal (callbacks generated on serialization settings) and construction of Avro schema.

At this point I probably won't have time to work on this in near term but would be happy to help if anyone else wants to tackle it.

from jackson-dataformats-binary.

@jlous BTW: If you change in Avro schema enum to string type, serialization and deserialization should work already.

from jackson-dataformats-binary.

I try to avoid enum in Avro schema. Serializing enum into string is a good idea.

@cowtowncoder
How do you want to control this feature?

I think creating a new AvroGenerator.Feature would be best from API standpoint, but I do not know how to access AvroGenerator.Feature from VisitorFormatWrapperImpl.expectStringFormat(JavaType).

BTW: Here is a draft PR, #496, where this feature is controlled by enableWriteEnumAsString() method:

AvroSchemaGenerator gen = new AvroSchemaGenerator()
    .enableWriteEnumAsString();

from jackson-dataformats-binary.

Ah. Sorry, saw this comment before adding a note on PR.

Yes, AvroGenerator.Feature would be better but I'd need to think of plumbing.

I think AvroGenerator might be available from SerializerProvider but not sure if that is properly initialized.

from jackson-dataformats-binary.

Let's continue discussion in PR #496.

from jackson-dataformats-binary.