Comments (3)
Actually there's another technical reason why I am pretty firmly for adding a new Proto-specific feature: DeserializationFeature
is not accessible from ProtobufParser
, being databind-level feature.
So even if I accepted semantic difference, it's not actually doable. :)
from jackson-dataformats-binary.
I guess originally I was thinking that since databind level enum String is not available, this is not doable.
Proto file does however have symbolic names so these could be surfaced.
Question then becomes whether READ_ENUMS_USING_TO_STRING
is the setting to use: its semantics are slightly different (namely, Enum.name() vs Enum.toString()), so I think that wouldn't work.
So I think that while allowing return-as-String makes sense, we'd probably should add Protobuf-specific feature instead.
That'd be added as ProtobufParser.Feature
(no features exist yet, so would need to be added).
This assumes that we keep track of enum String values.
New feature should be disabled by default for backwards compatibility.
from jackson-dataformats-binary.
Ah yes you are right maybe the meaning are different.
I see two ways of resolving this, either we are semantically close to the fact that we want from a port adapter perspective the symbolic name (because we expect the mapping to be done in the proto file) and the READ_ENUM_USING_TO_STRING
is quite close to what we want, or we could go with the ProtobufParser.Feature
as you proposed.
I have a preference for the former (standard feature) even if they are not strictly equal to what we want, because they are close enough to not confuse people. The enum are generated so its not we differentiate the toString() from the name() in our case.
from jackson-dataformats-binary.
Related Issues (20)
- Support for StreamReadConstraints for CBOR, Smile backends HOT 1
- Refactor Smile format module use of `ThreadLocal` to be bound to `SmileFactory` HOT 1
- Honor `READ_UNKNOWN_ENUM_VALUES_USING_DEFAULT_VALUE` feature with Protobuf HOT 5
- Rewrite Smile buffer recycling (`SmileBufferRecycler`) to use new (2.16) `RecyclerPool`, allow configuring use of non-ThreadLocal based pools HOT 2
- Rewrite Avro buffer recycling (`ApacheCodecRecycler.java`) to use new (2.16) `RecyclerPool`, allow configuring use of non-ThreadLocal based pools
- CVE in avro prior to v1.11.3 HOT 2
- Remove Smile-specific buffer-recycling
- Update `com.amazon.ion:ion-java` to 1.10.5 (from 1.9.5)
- (avro) Snyk Reports a Critical Vulnerability (org.codehaus.jackson:jackson-mapper-asl Improper Input Validation) -- NOT APPLICABLE (polymorphic deserialization) HOT 3
- Avro does not respect default values defined in schema HOT 8
- `IonReader` classes contain assert statement which could throw unexpected `AssertionError` HOT 1
- `IndexOutOfBoundsException` thrown by `IonReader` implementations are not handled HOT 1
- Avro generation failed with enums containing values with special characters HOT 3
- `IonReader` throws `NullPointerException` for unchecked invalid data
- `SmileParser` throws unexpected IOOBE for corrupt content HOT 1
- `IonParser.getIntValue()` fails or does not handle value overflow checks HOT 1
- CBOR: negative BigInteger values not handled correctly HOT 2
- More methods from `IonReader` could throw an unexpected `AssertionError`
- Unexpected `NullPointerException` thrown from `IonParser::getNumberType()` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jackson-dataformats-binary.