JsonFactory._optimizedStreamFromURL() fails on file URLs with spaces about jackson-core HOT 5 CLOSED

Actually, URLDecoder isn't supposed to accept forward slashes in the passed String as per the Javadoc, but the JDK implementation doesn't seem to care (it only handles + and percent-encoded stuff and keeps everything else as is).

from jackson-core.

Fixed, will be in 2.1.3.

from jackson-core.

Tatu, as far as I can tell this problem is still present in 2.1.3 and 2.1.4.

The fix that was applied in master (61d5bdd) looks correct, but 2.1.3 and 2.1.4 contain code doesn't actually allow a 'fall through' because there's a return statement that is identical to the one above which stops any fall through from happening:

                 if (path.indexOf('%') < 0) {
                     return new FileInputStream(url.getPath());

                 }
                 // otherwise, let's fall through and let URL decoder do its magic
                 return new FileInputStream(url.getPath());
            }
        }
        return url.openStream();

Basically, e0527c3 doesn't quite fix the problem but 61d5bdd does.

So, I think I'm write in saying that this fix will arrive in 2.2.0. Does this sound right or am I totally missing something?

from jackson-core.

Sounds like I forgot to merge in the fix for 2.1. Will add it there, which would suggest 2.1.5 is the release (as well as 2.2.0).

from jackson-core.

Ok. So the problem with merge was that one of return statements was left in place; so fix was incomplete.
Fixed, so it should finally work with 2.1.5 (and alreayd works I hope in 2.2.0-SNAPSHOT).

from jackson-core.