Git Product home page Git Product logo

Comments (8)

joaomcteixeira avatar joaomcteixeira commented on June 27, 2024

(sorry incomplete description)

And nothing appears in the left panel area.

from farseer-nmr.

skinnersp avatar skinnersp commented on June 27, 2024

from farseer-nmr.

joaomcteixeira avatar joaomcteixeira commented on June 27, 2024

find the peaklist here
https://pastebin.com/uG5XZUW8

from farseer-nmr.

skinnersp avatar skinnersp commented on June 27, 2024

The file won't be parsed as it doesn't have the Number column in it. I've tried to be strict with parsing of files and CCPN peaklists normally have Number as the first column header. I can loosen the parsing if required. What do you think?

from farseer-nmr.

joaomcteixeira avatar joaomcteixeira commented on June 27, 2024

The issue is different even.
The peaklist has generated by my Farseer_artificial_dataset_generator.py script.
It has de Number column, but columns are not sorted the same as CCPNMR.
Because Farseer parses column with pandas Dataframe based on .loc operation column sorting is not important.

Question:

Do you want to keep strick to the column order so that it becames compatible to your parsing scripts or do you prefer to loosen the parsing on the column order/sorting? If you want to be strick to the initial column order I just have to change the Farseer_artificial_dataset_generator.py, and that's it.

On the other hand, regardless of the answer to the above question, I think that the number and nature of columns should be kept strick.

from farseer-nmr.

skinnersp avatar skinnersp commented on June 27, 2024

I agree that we should keep column ordering strict and it's simpler to change the artificial dataset generator so that columns are in the same order as CCPNMR. That also means that we can state in documentation that we use official formats when parsing data.

from farseer-nmr.

joaomcteixeira avatar joaomcteixeira commented on June 27, 2024

agree,
I will change the generator accordingly

from farseer-nmr.

skinnersp avatar skinnersp commented on June 27, 2024

Excellent, we can close this then :-)

from farseer-nmr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.