Comments (5)
Implementing in AbstractCountry is the best. The bool
isKyotoMember = true
can be used to decide whether countries all allowed to take part.
from kyoto.
Why not:
Pass the reference to the abstract country as a parameter to trade protocol and then call those functions inside the protocol itself?
It would be proper encapsulation as it the exact moment of confirming the trade when the money and carbon offset should be updated.
from kyoto.
@farhanrahman can you update on the issue? From Tory's post in #40 I guess that you have decided to implement my solution. Is it introducing any problems?
from kyoto.
We've moved tradeProtocol into the countries package and made the relevant variables package protected, so that trade protocol can operate on them. We're doing testing on the alterations to trade protocol now. Once these tests are finished, trade protocol should work fully and completely to do carbon trading like we want to, and then we can work on CDM stuff.
from kyoto.
I think this was quite a good fix, moving TradeProtocol to countries package and using package protection!! Or else you can have countries hack the TradeProtocol and generate extra cash!!! I am quite happy with the work today :)
from kyoto.
Related Issues (20)
- Re-joining Kyoto defaults to Annex 1 membership HOT 1
- Non-Annex One Countries Never report their carbon emissions
- Trade Transaction Data
- Yearly function happening before new targets are set HOT 3
- KyotoUI - carbonOutput1990 is not added from UI
- TradeProtocol behaviour HOT 3
- Class kyoto/services/Economy#updateEconomyState uses a new Random in each invocation HOT 2
- NullPointerException: For NonAnnexOne Sims HOT 3
- TradeProtocol is unpredictable HOT 1
- Carbon Absorption added to Sanctioning
- Carbon Absorption added to carbon Targeting
- Carbon reduction handler runtime exception
- NonAnnexOne countries respond to all trade broadcast messages HOT 1
- Canada agent has copied code from non annex one HOT 1
- SOME ONE SORT OUT THE F*&^IN EMAIL HOT 1
- Kyoto UI breaking Presage CLI HOT 4
- Added exception to CarbonAbsorptionHandler(), some people's code needs fixing HOT 4
- Simulations on server GDPs are 6 orders of magnitude incorrect HOT 4
- Behaviours completion HOT 7
- Cyprus keeps failing at investing in arable land HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kyoto.