Git Product home page Git Product logo

Comments (5)

tumblerer avatar tumblerer commented on August 27, 2024

Implementing in AbstractCountry is the best. The bool

isKyotoMember = true

can be used to decide whether countries all allowed to take part.

from kyoto.

azyzio avatar azyzio commented on August 27, 2024

Why not:
Pass the reference to the abstract country as a parameter to trade protocol and then call those functions inside the protocol itself?
It would be proper encapsulation as it the exact moment of confirming the trade when the money and carbon offset should be updated.

from kyoto.

azyzio avatar azyzio commented on August 27, 2024

@farhanrahman can you update on the issue? From Tory's post in #40 I guess that you have decided to implement my solution. Is it introducing any problems?

from kyoto.

Sergeus avatar Sergeus commented on August 27, 2024

We've moved tradeProtocol into the countries package and made the relevant variables package protected, so that trade protocol can operate on them. We're doing testing on the alterations to trade protocol now. Once these tests are finished, trade protocol should work fully and completely to do carbon trading like we want to, and then we can work on CDM stuff.

from kyoto.

farhanrahman avatar farhanrahman commented on August 27, 2024

I think this was quite a good fix, moving TradeProtocol to countries package and using package protection!! Or else you can have countries hack the TradeProtocol and generate extra cash!!! I am quite happy with the work today :)

from kyoto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.