Git Product home page Git Product logo

Comments (11)

azyzio avatar azyzio commented on August 27, 2024

I don't understand the issue? Do you want to me to adjust the constants already?

from kyoto.

Sergeus avatar Sergeus commented on August 27, 2024

I don't really follow the math within the carbon reduction handler, so I'm not sure if the errors derive just from the GameConst stuff or the internal math of the handler. If it's possible to get it to output reasonable values for testing that would be awesome.

from kyoto.

azyzio avatar azyzio commented on August 27, 2024

OK, I will come up with some numbers.

from kyoto.

azyzio avatar azyzio commented on August 27, 2024

Ok, I have changed them so reasonable results should be found. Close the issue if it solved the problem.

from kyoto.

tumblerer avatar tumblerer commented on August 27, 2024

Not solved. carbonOutputChange in CarbonReductionHandler.invest() is throwing huge negative numbers.

from kyoto.

tumblerer avatar tumblerer commented on August 27, 2024

Ok, found the problem:

CarbonOutput in calculateCarbonOutput is calculated as energyOut *(1-cleanIndustry). However clean industry is not always a positive number less than 1.

Hence the roots of your quadratic need to be smaller.

from kyoto.

piotroslaw avatar piotroslaw commented on August 27, 2024

Is it not? assuming carbonOutput < energyOuput, dirtyIndustry is their ratio (0 <= dirtyIndustry <= 1), so should work.

But I think there is an easier and more easy to work with way to calculate all of it, without using quadratic equations. Will propose something later.

from kyoto.

azyzio avatar azyzio commented on August 27, 2024

Clean industry is always supposed to be positive number between 0 and 1. I guess the values of EnergyOutput and CarbonOutput in the simulation are not correct.

from kyoto.

Sergeus avatar Sergeus commented on August 27, 2024

The energyOutput and carbonOutput are initialized to correct values, but once the reduction handler supplies a massive change in one direction or the other, it breaks the formula for the second run at reduction.

from kyoto.

tumblerer avatar tumblerer commented on August 27, 2024

@azyzio and @piotroslaw could you work something out between you?

The values of energyOutput and carbonOutput are correct. Frankly, there's no way they can be incorrect, since they could take any value aslong as energyOutput>=carbonOut

from kyoto.

azyzio avatar azyzio commented on August 27, 2024

As the Carbon Reduction is now using a slightly modified model, this issue is no longer valid.

from kyoto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.