Comments (11)
I don't understand the issue? Do you want to me to adjust the constants already?
from kyoto.
I don't really follow the math within the carbon reduction handler, so I'm not sure if the errors derive just from the GameConst stuff or the internal math of the handler. If it's possible to get it to output reasonable values for testing that would be awesome.
from kyoto.
OK, I will come up with some numbers.
from kyoto.
Ok, I have changed them so reasonable results should be found. Close the issue if it solved the problem.
from kyoto.
Not solved. carbonOutputChange in CarbonReductionHandler.invest() is throwing huge negative numbers.
from kyoto.
Ok, found the problem:
CarbonOutput in calculateCarbonOutput is calculated as energyOut *(1-cleanIndustry). However clean industry is not always a positive number less than 1.
Hence the roots of your quadratic need to be smaller.
from kyoto.
Is it not? assuming carbonOutput < energyOuput, dirtyIndustry is their ratio (0 <= dirtyIndustry <= 1), so should work.
But I think there is an easier and more easy to work with way to calculate all of it, without using quadratic equations. Will propose something later.
from kyoto.
Clean industry is always supposed to be positive number between 0 and 1. I guess the values of EnergyOutput and CarbonOutput in the simulation are not correct.
from kyoto.
The energyOutput and carbonOutput are initialized to correct values, but once the reduction handler supplies a massive change in one direction or the other, it breaks the formula for the second run at reduction.
from kyoto.
@azyzio and @piotroslaw could you work something out between you?
The values of energyOutput and carbonOutput are correct. Frankly, there's no way they can be incorrect, since they could take any value aslong as energyOutput>=carbonOut
from kyoto.
As the Carbon Reduction is now using a slightly modified model, this issue is no longer valid.
from kyoto.
Related Issues (20)
- Re-joining Kyoto defaults to Annex 1 membership HOT 1
- Non-Annex One Countries Never report their carbon emissions
- Trade Transaction Data
- Yearly function happening before new targets are set HOT 3
- KyotoUI - carbonOutput1990 is not added from UI
- TradeProtocol behaviour HOT 3
- Class kyoto/services/Economy#updateEconomyState uses a new Random in each invocation HOT 2
- NullPointerException: For NonAnnexOne Sims HOT 3
- TradeProtocol is unpredictable HOT 1
- Carbon Absorption added to Sanctioning
- Carbon Absorption added to carbon Targeting
- Carbon reduction handler runtime exception
- NonAnnexOne countries respond to all trade broadcast messages HOT 1
- Canada agent has copied code from non annex one HOT 1
- SOME ONE SORT OUT THE F*&^IN EMAIL HOT 1
- Kyoto UI breaking Presage CLI HOT 4
- Added exception to CarbonAbsorptionHandler(), some people's code needs fixing HOT 4
- Simulations on server GDPs are 6 orders of magnitude incorrect HOT 4
- Behaviours completion HOT 7
- Cyprus keeps failing at investing in arable land HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kyoto.