Wrong mapping of ASCII coding about node-smpp HOT 7 CLOSED

data_coding: 0 is SMSC Default Alphabet (SMPP 3.4) (it may be ISO-8859-1, ASCII, GSM 7-bit default alphabet)
maybe a option set default charset of data_coding: 0 is better

The meaning of the data_coding=4 or 8 is the same as in SMPP 3.3. Other values in the range 1-15 are reserved in SMPP 3.3. Unfortunately, unlike SMPP 3.3, where data_coding=0 was unambiguously GSM 7-bit default alphabet, for SMPP 3.4 and higher the GSM 7-bit default alphabet is missing in this list, and data_coding=0 may differ for various Short message service centers—it may be ISO-8859-1, ASCII, GSM 7-bit default alphabet, UTF-8 or even configurable per ESME. When using data_coding=0, both sides (ESME and SMSC) must be sure they consider it the same encoding. Otherwise it is better not to use data_coding=0. It may be tricky to use GSM 7-bit default alphabet, some Short message service centers requires data_coding=0, others e.g. data_coding=241.

http://www.developershome.com/sms/gsmAlphabet.asp

https://en.wikipedia.org/wiki/Short_Message_Peer-to-Peer

from node-smpp.

i use this to correct encoding

pdu.short_message.message=defs.encodings.LATIN1.decode(defs.encodings.ASCII.encode(pdu.short_message.message));

from node-smpp.

I guess, something wrong in https://github.com/farhadi/node-smpp/blob/master/lib/defs.js#L1212-L1213 this line. What do you think?

Why IA5 and ASCII data encoding is the same? Encoding dont not work correctly on server side implementation? I changed the codes following and test on server side. I works but I am using my own GSM-7 encoder and decoder if data encoding is 1. @farhadi What is that mean?

    ENCODING: {
        ASCII:    0x00, 
        IA5:      0x01,
        LATIN1:   0x03,

from node-smpp.

i think it because data_coding: 0x00 ban be both ASCII and GSM 03.38, this library see 0x00 as GSM 03.38 while my smpp server see 0x00 as ASCII.

may be user should specify which encoding is when data_coding= 0x00

from node-smpp.

Hi @chouex , What change if we change this value as 0x00? Is something went wrong? I tested on 0x00, apperently, nothing changed.

from node-smpp.

@chouex I fixed this issue at 68288cb
Now you can change default encoding for data_coding:0 like this:

smpp.encodings.default = 'LATIN1';

@hkulekci I took encoding values from the spec (4.7.7 data_coding), duplicates are just alternative names.

from node-smpp.

Thank you @farhadi . I understand that, in fact, IA5 and ASCII has same code on smpp.

from node-smpp.