Git Product home page Git Product logo

Comments (4)

maximecb avatar maximecb commented on June 23, 2024 1

I think that the cleanest way to do this would be to create a separate wrapper that just produces an RGB image, and maybe also drops the text string if you don't need it. I would create a separate wrapper rather than setting some boolean variable on the environment. If you create that, I would merge it.

from minigrid.

planetceres avatar planetceres commented on June 23, 2024

Optionally dropping the text string for baseline comparisons was another priority for me, so I'm glad you mentioned that. I had started with the wrapper approach and agree it makes more sense, but I was trying to avoid creating multiple wrappers for each variant of image type along with optional text. This may not be a concern though if the observation wrappers are more meant as a temporary solution to deal with dict observations.

from minigrid.

planetceres avatar planetceres commented on June 23, 2024

This makes sense to me based on the current wrapper syntax, although could use some refactoring later at some point:

planetceres@b16c3f6

from minigrid.

maximecb avatar maximecb commented on June 23, 2024

I don't think the wrappers are just a temporary solution. I think different people will want different inputs for their use cases. I think it's just cleaner to separate the environment from wrappers that format the output however you want it.

I would just create an RGBImageWrapper, which doesn't flatten the image and doesn't include the text (no boolean argument).

from minigrid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.