Comments (3)
detailed information on this bug was described in the below mailing list announcement:
https://groups.google.com/g/mcx-users/c/l-glzQk1UgU
quoted below
What version was affected
we found that this bug appeared in MCX and MCXCL v2020, could be even earlier (although Shijie believes it was not there when we completed photon-sharing between 2019-2020)
What type of simulations were affected
all single-pattern simulations using 'pattern' or 'pattern3d' source type (excluding multi-pattern simulations using photon-sharing) with non-binary sources have been giving incorrect volumetric outputs (fluence/flux/energy)
photon-sharing based simulations, surface diffuse-reflectance outputs and detected photon outputs were not affected. other source types (fourier etc) were not affected.
simulations using binary (0-1) single pattern/pattern3d were not affected
What happened
our code mistakenly multiplied the photons launch weight twice when saving fluence/energy deposition. This effectively make the simulated pattern squared. In other words, if you simulate a pattern [0.1,0.2;0.5,1], mcx/mcxcl effectively simulated [0.01,0.04;0.25,1].
we discovered the same issue in Aug 2020, but was only fixed it in diffuse reflectance outputs (c04bff5); but somehow we missed the fluence output.
How to fix
If you happen to use non-binary single-pattern simulation in your work, please immediately update your mcx/mcxlab/mcxcl/mcxlabcl to the Github version at
https://mcx.space/nightly/github/
We sincerely apologize for the inaccurate results mcx/mcxcl produced. Please rerun your simulations and verify if your results were affected.If you use pmcx, I have already updated pmcx to v0.2.12 after fixing this bug. Please upgrade your pmcx from pypi (https://pypi.org/project/pmcx/).
from mcx.
Hello Fang! Does this bug affect mmc simulations?
from mcx.
@Giovannatc, no, it does not.
from mcx.
Related Issues (20)
- Error in make HOT 1
- pmcx buffer overflow error if bc parameter has 12 characters HOT 1
- "misaligned address" error when using cfg.invcdf and cfg.angleinvcdf
- Failed to apply double-float-buffer approach in #41 to `dref` cause loss of accuracy
- Tissue propoerty for different wavelenght HOT 2
- `pmcx.mcxlab` fails to typecast `traj.id` output from float32 to uint32
- mcx2json unable to export simulations of continuously-varying media
- mcxlab: Where to find "sphdiffusionslab.m" required by "demo_validation_heterogeneous.m"? HOT 1
- Support per voxel mua/mus/g/n continuous medium type
- Different scattering coefficient of water in demo_skinvessel.m compared to mcxyz.c HOT 1
- get absorbed energy by object HOT 8
- svmc is broken after commit 7e1aec0
- pmcx dettpsf overwrites input detp structure HOT 1
- Gaussian divergence for slit source HOT 3
- Replay fails when simulating with multiple light sources HOT 6
- Post v2024.2 release actions
- Multi-source simulation fails to return the source ID for detected photons and trajectories
- Using base64 as compression method resulting in double base64 encoding
- mcxsvmc isosurface normal direction is flipped in octave compared to matlab
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mcx.