Git Product home page Git Product logo

Comments (8)

joshuaboniface avatar joshuaboniface commented on May 28, 2024 1

Just for context: the big difference between a .deb and the AUR is that AUR packages are built on the client machine at install, while .debs are built remotely and the full binaries are sent. This is running into problems with node_modules because it tries to do a lot of .deb magic on them and fails. So there has to be a better way here, but I'm also thinking that this might not be entirely possible, at least not in a clean way that won't result in a 1.6+GB(!) .deb.

from jellyseerr.

joshuaboniface avatar joshuaboniface commented on May 28, 2024

Agreed, willing to take this on.

from jellyseerr.

joshuaboniface avatar joshuaboniface commented on May 28, 2024

So, Debian packaging here is going to be quite difficult to do "properly", as splitting the various parts out into Debianlized folders seems to be impossible.

I can do a hacky alternative though of putting everything under /opt/jellyseerr, which isn't quite as nice (and wouldn't be accepted to an upstream) but will work for now.

from jellyseerr.

Fallenbagel avatar Fallenbagel commented on May 28, 2024

So, Debian packaging here is going to be quite difficult to do "properly", as splitting the various parts out into Debianlized folders seems to be impossible.

I can do a hacky alternative though of putting everything under /opt/jellyseerr, which isn't quite as nice (and wouldn't be accepted to an upstream) but will work for now.

How about something similar to the AUR package? Is that doable? Where the config folder is symlinked?
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jellyseerr#n60

from jellyseerr.

joshuaboniface avatar joshuaboniface commented on May 28, 2024

That is possible, but I don't think it's good practice to do so.

from jellyseerr.

joshuaboniface avatar joshuaboniface commented on May 28, 2024

The other issue would be packaging the node_modules in the .deb which makes it huge. I'm trying to see if there's a way around that but I'll need to do some more reading into how to properly package NodeJS projects in Debian.

from jellyseerr.

Fallenbagel avatar Fallenbagel commented on May 28, 2024

Just for context: the big difference between a .deb and the AUR is that AUR packages are built on the client machine at install, while .debs are built remotely and the full binaries are sent. This is running into problems with node_modules because it tries to do a lot of .deb magic on them and fails. So there has to be a better way here, but I'm also thinking that this might not be entirely possible, at least not in a clean way that won't result in a 1.6+GB(!) .deb.

I guess at that point and install script would be better then? 🤔

from jellyseerr.

joshuaboniface avatar joshuaboniface commented on May 28, 2024

I've done some more digging, and for simple NodeJS projects, https://github.com/heartsucker/node-deb seems like a good solution. But from what I've seen of it Overseerr (and hence Jellyseerr) is not simple. Most of all, the fact that the node_modules dir is over 1.6GB pretty much precludes making a sensible .deb here, as that entire thing needs to be included. We just don't have the AUR benefit of running things like yarn build at install time.

So I definitely think an installer script is the better bet here.

from jellyseerr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.