Git Product home page Git Product logo

Comments (32)

LitoMore avatar LitoMore commented on May 25, 2024 4

Hi, I'm the maintainer of Simple Icons. Once you're ready, PRs are welcome. Feel free to ping me if you need help with contributing.

My suggestion for the badge is to use the whiteish color for the left-side background. For example:

<!-- I used the foodpanda icon as an example since your logo is not on Simple Icons yet. -->
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd&style=flat-square)






from faker.

Shinigami92 avatar Shinigami92 commented on May 25, 2024 3

face-filled-1 wins for me

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024 2

Team Decision

  • We will use face-filled-1
  • We will create a PR to upload the icon there.

from faker.

ianzone avatar ianzone commented on May 25, 2024 1

to add a badge to my readme file indicates i'm using fakerjs in my project.

from faker.

Shinigami92 avatar Shinigami92 commented on May 25, 2024 1
image

I like
image
the most

from faker.

Shinigami92 avatar Shinigami92 commented on May 25, 2024 1

And again,
image
wins for me

I think I found my favorite and decided (for me)

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

For what purpose do you need the logo?

from faker.

xDivisionByZerox avatar xDivisionByZerox commented on May 25, 2024

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷

Why would you open an issue here instead at the simple icon repo, tho? 🤔 (I have no idea how the process works)

from faker.

ianzone avatar ianzone commented on May 25, 2024

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷

I don't know if this issue can harm anybody.

Why would you open an issue here instead at the simple icon repo, tho? 🤔

I guess the author has a better idea about how the icon should look like.

(I have no idea how the process works)

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

from faker.

xDivisionByZerox avatar xDivisionByZerox commented on May 25, 2024

I don't know if this issue can harm anybody.

What I wanted to say is: This "features" look very low effort/maintainable for us. So it would not hurt to give it a try.

I guess the author has a better idea about how the icon should look like.

I see (and also read it in the affiliate section in their contributions guidelines). Guess we can discuss it on this week's team meeting.

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

Thank you for the link. I was already reading their documentation and intended to rework my comment with a funny twist like: "(I don't know how their process works) I got it now!"
I did not expect you to answer this fast 😄

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

How about this one. It is based on https://github.com/faker-js/faker/blob/next/docs/public/logo.svg

Powered by FakerJS

We might have to clean it up some more though, because at low screen sizes it gets indistinguishable.

from faker.

ianzone avatar ianzone commented on May 25, 2024

The outline is good, could you add some color to it? Otherwise, it would be very dark on a dark background.
image

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

The icons have to be black and transparent. I can add a white background for better visualization on darkmode.

Powered by FakerJS

from faker.

ianzone avatar ianzone commented on May 25, 2024

looks cool

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

Here a variant with only the face:

Powered by FakerJS

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

IMO it is still very had to see properly when small.
Maybe we have to focus just on the face and maybe fill it/invert the interior.

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

Here vitest for comparison:

Powered

from faker.

ianzone avatar ianzone commented on May 25, 2024

Or just the magic hat?

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

face-2

Powered by FakerJS

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

Or just the magic hat?

I'll try that tomorrow.

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

hat-1

Powered by FakerJS

from faker.

ianzone avatar ianzone commented on May 25, 2024
image

from faker.

matthewmayer avatar matthewmayer commented on May 25, 2024

I think the panda head is most visible at small sizes.

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

Please don't forget that there is usually no white background:

shield-bare
shield-face
shield-face-filled
shield-hat

from faker.

ianzone avatar ianzone commented on May 25, 2024

the icon color can be set here btw https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#7-update-the-json-data-for-simpleiconsorg

Panda head or magic hat works for me.

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

I will make some more variant soon.
Especially those with filled faces with default and no rotation.

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

face-3 shield-face2

Powered by FakerJS

from faker.

Shinigami92 avatar Shinigami92 commented on May 25, 2024

face-3 shield-face2

Powered by FakerJS

dont like :(

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

face-filled-2 shield-face-filled2

Powered by FakerJS

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

face-filled-3 shield-face-filled3

Powered by FakerJS

from faker.

ST-DDT avatar ST-DDT commented on May 25, 2024

For better comparison:

  • face-filled-1 shield-face-filled - ~50% rotation
  • face-filled-2 shield-face-filled2 - original rotation
  • face-filled-3 shield-face-filled3 - zero rotation

from faker.

xDivisionByZerox avatar xDivisionByZerox commented on May 25, 2024

I'm "soft blocking" this issue as I'd like to talk about UI/UX related topics in our next teem meeting, next thursday.

from faker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.