Git Product home page Git Product logo

Comments (2)

matthewmayer avatar matthewmayer commented on May 25, 2024

i feel the way it calculates "age" in the test is weird. it basically boils down to doing this:

function getAge(birthdate, refDate) {
    const value = birthdate.valueOf()
    const refDateValue = refDate.valueOf()
    const deltaDate = new Date(refDateValue - value)
    return deltaDate.getUTCFullYear() - 1970
}

but that can be off for leap years for example this returns 1, not 0

console.log(getAge(new Date('2019-03-01T01:00:00'), new Date('2020-02-29T01:00:00')))

from faker.

matthewmayer avatar matthewmayer commented on May 25, 2024

Where getAge is defined as above, there's a roughly 1/365 chance of failure:

const refDateFixed = new Date("2024-04-02T12:00:00");
faker.seed(123456);
const results = faker.helpers.multiple(()=>getAge(faker.date.birthdate({mode:"age", min:21, max:21, refDate:refDateFixed}), refDateFixed),{count:1000000})
const counts = results.reduce((acc, age) => (acc[age] = (acc[age] || 0) + 1, acc), {})
console.dir(counts)
//{ '21': 997248, '22': 2752 }

from faker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.