Comments (3)
Fair point @chatox , this relates to our last conversation about k and window_size. Certainly k can be either smaller or bigger than the windows_size value used in the query, as of the way the code is written right now.
But this does not limit us to fix this situation and make it better and more consistent with the experience.
Your solution works fine for me, we only need to add a new exception for this case in the reranker function.
Now, when k < windowsize, the M-Table should be applied up to position k.
This will be always like this.
from fairsearch-fair-for-elasticsearch.
Now that I think more on this problem, this situation will only occur when using the fixed lookup for proportion strategy. Ref #2
from fairsearch-fair-for-elasticsearch.
dd8a11a handles the k > elementsToRescore situation when the proportion is fixed. this situation can not happen when the proportion is variable.
from fairsearch-fair-for-elasticsearch.
Related Issues (20)
- Create an integration test case based on the XING dataset HOT 8
- Create an integration test case based on the German credit score dataset HOT 4
- Performance tests
- Distribution method HOT 1
- M table calculations should be cached in elasticsearch
- Add https://readthedocs.org/ as source of our plugin documentation HOT 2
- Find out what is the highest ranking enhancement for a protected candidate HOT 1
- Create a unit test for the generation of table M HOT 7
- Write the AlphaAdjustment as an utility Class HOT 2
- Mtable names should be automatically generated
- The adjust alpha process and the mtable generation are disconnected
- Configure min k,p,alpha for the first release HOT 1
- Throw an exception if k is too small or p is too small HOT 1
- Deal with cases in which p and k are small, and alpha is large, so no re-ranking is necessary HOT 1
- Fix build against Elasticsearch 6.3.x HOT 1
- Remove or document the restriction that index must have at most 1 shard + 1 replica for the plugin to work HOT 1
- Catch shard failure and throw reasonable exception when doing a fair query against a non-existing mtable
- FairRescoreBuilder: Queue construction for fair Rescore should be reviewed HOT 1
- If no results, es tries to create an mtable with k=0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fairsearch-fair-for-elasticsearch.