Git Product home page Git Product logo

Comments (3)

purbon avatar purbon commented on June 11, 2024

Fair point @chatox , this relates to our last conversation about k and window_size. Certainly k can be either smaller or bigger than the windows_size value used in the query, as of the way the code is written right now.

But this does not limit us to fix this situation and make it better and more consistent with the experience.

Your solution works fine for me, we only need to add a new exception for this case in the reranker function.

Now, when k < windowsize, the M-Table should be applied up to position k.

This will be always like this.

from fairsearch-fair-for-elasticsearch.

purbon avatar purbon commented on June 11, 2024

Now that I think more on this problem, this situation will only occur when using the fixed lookup for proportion strategy. Ref #2

from fairsearch-fair-for-elasticsearch.

purbon avatar purbon commented on June 11, 2024

dd8a11a handles the k > elementsToRescore situation when the proportion is fixed. this situation can not happen when the proportion is variable.

from fairsearch-fair-for-elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.