Comments (5)
Added a note about Google Play performance in the readme
from aso.
Just confirming that something's going wrong when it comes google-play-scraper
dep module.
It takes so long to retrieve all apps from store to score, since it takes them with { fullDetail: true, num: 100}
opts in the search method.
If you run your example with a DEBUG=google-play-scraper
env variable, you can see all the requests being made on your terminal.
Running it here, it took over 2 minutes (once it took even 4 minutes to finish) all the times to finish the score to google-play.
If I find a solution, I'll let you guys know.
from aso.
This is not something going wrong, just working as expected. Google doesn't provide a proper API for the app details, so everything has to be scraped, thus resulting in an extra request per app to get the details needed for score calculations. (I think I had a warning about this in the README at some point, I guess I removed it.)
Memoization helps to mitigate this for recurrent requests, but obviously the proper way to go to get fast calculations would be to scrape the data and store it in a DB, then consuming from there for the calculations, but that's out of the scope of this module.
from aso.
Sorry, I wasn't clear on what I had written.
I know that, by a technical aspect, the code is working exactly as expected.
I'm just wondering if we could do something to dim the response time or at least point out in the doc some warning with more evidence for google play store, since 2 ~ 4 minutes is a long long time to wait, and comparing it with app store lib we can note a rather discrepant response time difference.
So, I think that the simple user is very unlikely to understand quickly the reason, because, he doesn't know the google-play-scraper
detail implementation when starting to use this module, and if we can't change the way the method works, maybe update the docs to alert about this fact would be nice.
from aso.
Agreed, this definitely calls for an explanation in the readme.
from aso.
Related Issues (20)
- iTunes Visibility Doesn't seems to work? HOT 4
- Big Bug - Memory leak when use aso lib HOT 6
- TypeError: Cannot read property 'split' of undefined HOT 13
- support keyword phrases
- Speed up HOT 1
- integration tests
- document debug in readme
- memoization should be optional
- avgDaysSinceUpdated broken (because google-play-scraper bug)
- Google Plasy Scrape Not Work check competitors HOT 4
- UnhandledPromiseRejectionWarning HOT 3
- [App Store] Search suggestion always returns empty array HOT 2
- Score command not working correctly HOT 4
- Please update dependencies for google play scraper
- 404 App not found HOT 1
- how to set request proxy?
- Unhandled promise rejection. HOT 8
- Is this project still maintained? HOT 2
- Stopped working last week ("Invalid Category 6025") HOT 1
- TypeError: Cannot read properties of undefined (reading 'map')
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aso.