Git Product home page Git Product logo

Comments (5)

facundoolano avatar facundoolano commented on July 20, 2024 1

Added a note about Google Play performance in the readme

from aso.

icaroponce avatar icaroponce commented on July 20, 2024

Just confirming that something's going wrong when it comes google-play-scraper dep module.

It takes so long to retrieve all apps from store to score, since it takes them with { fullDetail: true, num: 100} opts in the search method.

If you run your example with a DEBUG=google-play-scraper env variable, you can see all the requests being made on your terminal.

Running it here, it took over 2 minutes (once it took even 4 minutes to finish) all the times to finish the score to google-play.

If I find a solution, I'll let you guys know.

from aso.

facundoolano avatar facundoolano commented on July 20, 2024

This is not something going wrong, just working as expected. Google doesn't provide a proper API for the app details, so everything has to be scraped, thus resulting in an extra request per app to get the details needed for score calculations. (I think I had a warning about this in the README at some point, I guess I removed it.)

Memoization helps to mitigate this for recurrent requests, but obviously the proper way to go to get fast calculations would be to scrape the data and store it in a DB, then consuming from there for the calculations, but that's out of the scope of this module.

from aso.

icaroponce avatar icaroponce commented on July 20, 2024

Sorry, I wasn't clear on what I had written.

I know that, by a technical aspect, the code is working exactly as expected.

I'm just wondering if we could do something to dim the response time or at least point out in the doc some warning with more evidence for google play store, since 2 ~ 4 minutes is a long long time to wait, and comparing it with app store lib we can note a rather discrepant response time difference.

So, I think that the simple user is very unlikely to understand quickly the reason, because, he doesn't know the google-play-scraper detail implementation when starting to use this module, and if we can't change the way the method works, maybe update the docs to alert about this fact would be nice.

from aso.

facundoolano avatar facundoolano commented on July 20, 2024

Agreed, this definitely calls for an explanation in the readme.

from aso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.