Special chars in attribute names break feed settings about oxid-eshop-module HOT 8 CLOSED

@m-schiewi the v4.1.0 is out https://github.com/FACT-Finder-Web-Components/oxid-eshop-module/releases/tag/v4.1.0

from oxid-eshop-module.

Hi @bissie and thanks for reporting.
This is going to be fixed in next release

from oxid-eshop-module.

Issue not fixed in 4.1.0

steps to reproduce:

• create an attribute in shop titled "Webhop Label '%'"
• insert line console.log(newValue) after attribute-rows.js:41
• notice that string newValue ends like ".... Webshop Label " leaving out the percentage char and any characters following, consequently any attempt for JSON.parse() fails

-root cause can be found in views/admin/blocks/factfinder_config_field_attributes.tpl:5
[{$availableAttributes|@json_encode}] itself gives valid json but since the fact, that it's enclosed in single quotation like
available-attributes='[{$availableAttributes|@json_encode}]' it fails immedeately if $availableAttributes contains any quotation mark.

from oxid-eshop-module.

hi @m-schiewi
thanks for noticing that. It looks that smarty @json_encode does not properly encode that characters like " and ' and we need to use regular json_encode function with additional encoding flags before assigning to a template variable. This will be fixed in next release.

The 4.1.0 is not yet released. Currently is postponed as we are waiting for the WebComponents v4.0.7 to be released before.

from oxid-eshop-module.

hi @m-schiewi additional encoding is already in master.
4209dc4
With that fix, the attribute names containing apostrophes or quotes should not break the attribute rows component.

Version v4.1.0 will be released soon

from oxid-eshop-module.

@a-laurowski I am confused: 4.1.0 is listed at packagist and installed on my side...

from oxid-eshop-module.

hi @m-schiewi
the problem here is we already pushed the v4.1.0 tag on Wednesday because we were about to release but then, we postpone that. But since tag was already in repository it was automatically loaded by packagist. if you checked the release lists on github you would notice though, that last official release was 4.0.2, and v4.1.0 was still a draft, not visible as official release.
Sorry for inconvenience.
I will update you as soon as release is out

from oxid-eshop-module.

thanks a lot!

from oxid-eshop-module.