Support for custom resolvers with Hydra about dora HOT 2 CLOSED

Indeed your solution works.

I initially tried something similar but since I put register_new_resolver() inside my if __name__ == '__main__': block it wasn't executed, which made me (wrongly) think that when using the dora command, only the piece of code inside hydra_main was executed.

Maybe mentioning this point in the README could be helpful, insisting on the fact that the register_new_resolver should be outside of the if __name__ == '__main__', which is a bit unusual.

Thanks a lot!

from dora.

I'm wondering why not do it outside of my_hydra_main ? it doesn't seem like you are using any of the Hydra API to register new resolver, so you could have something like

def register_my_resolver():
    for name, resolver in extra_resolvers.items():
        OmegaConf.register_new_resolver(name, resolver)

@hydra_main(...)
def main(cfg):
    ...

register_my_resolver()

Note that the position of the call to register_my_resolver() doesn't actually matter, and could be before main(). I would tend to favor this option as this makes it clear from the code, that the registration of the resolvers will leak to any other call to OmegaConf, and I would tend to think a PR is not needed for that use case. Potentially an update to the README to show this pattern.

Regarding question 1., get_xp() needs to resolve the config because this is how the signature is actually derived. It will resolve the full config, compare it with the base config and build a delta. The hash of the delta is then the signature.

from dora.