Add support for LIKE operator about velox HOT 7 CLOSED

DuckDB has a custom LIKE implementation not using regular expressions: https://github.com/duckdb/duckdb/blob/master/src/function/scalar/string/like.cpp

DuckDB folks considered switching to RE2, but found that RE2 is 2-4x slower: duckdb/duckdb#157

Same for OmniSciDB: https://github.com/omnisci/omniscidb/blob/master/Utils/StringLike.cpp#L94

CC: @biswapesh @spershin @amitkdutta

from velox.

Masha and I discussed this last week. We concluded that the current re2 based implementation is sufficient for the purpose of tpch coverage. There will be subsequent work when optimizing tpch queries.

from velox.

More changes are needed in presto_cpp for the e2e TPC-H query.

from velox.

https://github.com/facebookexternal/presto_cpp/pull/537 for presto_cpp changes

from velox.

@aditi-pandit Aditi, have you had a chance to check performance of LIKE to see if we need to special case starts-with, ends-with and contains expressions. E.g. can we check whether RE2 is already optimized for foo%, %bar and %foo% patterns and if not provide non-regexp implementation for such patterns.

CC: @kgpai @spershin @tanjialiang

from velox.

Seems this is already done. Shall we close the issue? @aditi-pandit

from velox.

@yingsu00 : I have not spent much time benchmarking the like operator. But I will open a separate issue for it and close this one.

Opened issue #872

from velox.