Comments (15)
Hello! What BOLT version do you use? Using the latest bolt with this commit (llvm/llvm-project@4c14519) should fix the problem
from bolt.
@yota9 thank you for replying.
I am using the latest bolt, and this commit has been merged into the latest bolt. The commit doesn't work.
from bolt.
@Haishan312 May I see the binary or at least function objdump + readelf section/segments output? Probably the binary would be preferable way, since I need to see exactly what is going on there
from bolt.
@yota9 You can download the binary from this repo git clone https://github.com/Haishan312/bolt-fixbugs.git
. Because of github issue limit the size of attach file.
from bolt.
@Haishan312 Yes, I was able to download it, thanks. Also I need your bolt options (and might be fdata file) to reproduce the issue
from bolt.
@yota9 bolt options is llvm-bolt ${binary_name} -o ${binary_name}.bolt -data=perf.fdata -reorder-blocks=cache+ -reorder-functions=hfsort -split-functions=2 -split-all-cold -split-eh -dyno-stats --update-debug-sections -v=2
and the fdata file
502.fdata.zip
from bolt.
@Haishan312 Thanks, I was able to repro the issue, it is not related to plt, but I will try to resolve it.
from bolt.
@yota9 that's great, thank you.
I have another case which is related to plt. I am recovering a small binary
from bolt.
Hello @Haishan312 ! Sorry for long reply. I've checked out your binary, the problem is known to me and I've raised it earlier with goland support. Nevertheless I've found the way to fix it easily with this commit llvm/llvm-project@fd96049 , please try to rebase the bolt on the latest commits and check if there are any other problems. Thank you!
from bolt.
@yota9 Thank you very much. This commit resolves my problem.
from bolt.
@Haishan312 Great!
Please close the issue if everything is solved :)
from bolt.
@yota9 Your patch would generate an illegal instruction on aarch64 platform. when I use llvm-objdump tools to dump assembly. I get the an unknown instruction, such as:
ae3254: 60 d9 72 b8 ldr w0, [x11, w18, sxtw #2]
ae3258: 00 b2 fc 7f unknown
ae325c: e0 03 11 aa mov x0, x17
And you can download original attach files.
illegel_instr.tar.gz
from bolt.
Hello @Haishan312 ! I don't think the patch has anything to do with that. For some reason tbz instruction was not relaxed, I would check the reason soon. Thank you for reporting!
from bolt.
@Haishan312 The problem was found in another part of LLVM https://reviews.llvm.org/D128740 . It may take some time before approve would be received, so fill free to apply this patch manually :)
UPD The patch has landed.
from bolt.
Assuming the issue is resolved with rGb27d6ffe4e4a.
from bolt.
Related Issues (20)
- A dump about function cannot be properly disassembled when use -use-old-text HOT 2
- perf2bolt: crashes with assertion. HOT 5
- A NullPtrException after BOLT on libart.so HOT 2
- BOLT/LLVM? does not preserve prefixes on conditional branches HOT 2
- ELF32 support HOT 1
- BOLT only failed with --hugify HOT 13
- Why skip-function when it jump to itself? HOT 7
- Why Is registerName Executed Twice for a Symbol? HOT 1
- How do I run BOLT on a benchmark of HHVM? HOT 1
- A Problem About .got Table Updates HOT 4
- Promote BOLT to the chromium team HOT 11
- A Problem about IsSimple be used in disassemble
- Any ideas to support riscv architecture? HOT 5
- clang14 build with -update-debug-sections rewrite debug info core HOT 14
- A fatal error about -update-debug-sections HOT 3
- Any suggest to couple two functions? HOT 11
- How to use --hugify option? HOT 20
- Failed to BOLT HOT 2
- [C++] Exceptions catch leads to Segmentation fault
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bolt.