Comments (5)
Interesting why this behaviour is applied to recoverable errors, I expected a failed client component to be called only once, then client error can be propagated to Error Boundary parent.
We retry client components one more time with sync rendering to check if we can recover.
from react.
If wrapped in Suspese component cause hydration error, React will render this component hungreds or event thousands times.
This is intended behavior. React will re-render on hydration mismatches inside Suspense
in an attempt to recover. This should not break any app behavior. Though the number here is quite high. What are the steps to repro this behavior in the repo you linked?
The second case is violating the Rules of React. Class component constructors must be pure i.e. calling setTimeout
in them is not allowed and leads to undefined behavior.
from react.
This is intended behavior. React will re-render on hydration mismatches inside
Suspense
in an attempt to recover. This should not break any app behavior. Though the number here is quite high.
As I know React will render suspensed child multiple times when need to wait thrown promise to be resolved?
Interesting why this behaviour is applied to recoverable errors, I expected a failed client component to be called only once, then client error can be propagated to Error Boundary parent.
What are the steps to repro this behavior in the repo you linked?
The same steps from issue, but this line with class component need to be removed - https://github.com/SuperOleg39/react-ssr-perf-test/blob/react-bug-suspense-child/react-18-stream/src/App.js#L52C12-L52C27
- Clone repo
https://github.com/SuperOleg39/react-ssr-perf-test
- Switch to branch
react-bug-suspense-child
- Remove this component from App render
- Run application build and server -
cd react-18-stream && yarn && yarn start
(use Node.js 16) - Open application page at
http://localhost:4000
- Reload page with React Proiler recording
from react.
One more thing, @eps1lon, important thing in reproduction branch - a big React component inside Suspense boundaries.
Looks like this problem occurs only when selective hydration applied to component, and it will render in concurrent mode.
For small components React did hydration fast, and probably sync.
from react.
Hello, @eps1lon!
Do I need to send a more information about reproduction steps, or it is enough?
from react.
Related Issues (20)
- ..
- [DevTools Bug]: 5.2.0 is not available for Firefox HOT 4
- [DevTools Bug] getCommitTree(): Invalid commit "1" for root "445". There are only "1" commits.
- [eslint-plugin-react-hooks] Missing type declarations HOT 2
- [React 19]
- Bug: useEffect is triggered even if the array as dependency variable wasn't changed. HOT 4
- [DevTools Bug]: React Devtools not working neither on vite or cra project HOT 5
- ..
- Bug: Error Recovery Mechanism Overwriting Initial Rendering Errors in Concurrent Mode HOT 1
- Bug: Empty `style={}` object values cause hydration warnings in React 18.3.1 - Includes solution HOT 1
- [React 19] Cannot assign to readonly property HOT 8
- Unexpected Initial State Jump in 'useEffect" with 'setTimeout' and State Dependencies HOT 3
- React[19] Module '"react"' has no exported member 'useActionState'. HOT 2
- Bug: effect runs with stale state values outside of Concurrent React HOT 1
- Feature Request: ESLint hooks rule for accessing previous state when deriving new state
- Bug: Weird Behavior of useCallback() hook When Variables or States Are defined before and after the Callback (ES5) HOT 5
- Bug: div: `ref` is not a prop HOT 2
- Bug: useFormStatus pending state is reset when component state is updated HOT 5
- [React 19] TEST HOT 1
- `FALLBACK_THROTTLE_MS` slows tests down significantly - could it be configurable? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.