Comments (3)
from react.
Hey there @PradeepNedun! 👋
I can't access the sandbox you linked to. Did you forget to set it to be publicly viewable?
Thanks! ❤️
from react.
@PradeepNedun I don't see anything wrong here. the memo re-render
log only fires when the dependencies of the useMemo changes (specifically only when the tab
changes, since todos
is created once in the module scope and never updated.
The memo value
log fires any time the TodoList
component renders (including when changing the theme) but that's because you're calling that function in render. So of course, if you call a function in render, then that function is called whenever the component renders.
To fix, you filter the todos and return them from useMemo
directly, instead of returning a function:
const filteredTodos = useMemo(() => {
console.log('memo')
return filterTodos(todos, tab);
}, [todos, tab]);
// ...
filteredTodos.map((todo) => <div> ...</div>);
With this, the expensive filterTodos function will only run when either the todos
or tab
values change.
from react.
Related Issues (20)
- Larger files upload rejection message instead of net::ERR_CONNECTION_RESET
- Bug: yo HOT 1
- Bug: refObj returned from useRef is not sealed
- Bug: Input of type number is incrementing/decrementing on mouse scroll
- Bug: render time differ depending on load
- How can I force update a class component in SyncLane? Can we permanently expose runWithPriority API? HOT 13
- Bug: StrictMode is not preventing side effects HOT 2
- [DevTools Bug]: After updating to version 5.1 the Dev tools fails to inspect elements
- Bug: HOT 1
- [React 19] Async transitions race condition handling
- Bug: React 18.3 warning says to import `act` from `react`, only `unstable_act` exists HOT 3
- Bug: "React Developer Tools" Chrome Extension unable to profile page rendering
- Bug: Source not displayed in DevTools HOT 1
- Bug:
- [React 19] useTransition()'s pending state does not go back to false (revision 94eed63c49-20240425) HOT 3
- Changelog for 18.3 is missing HOT 1
- [React 19] Removal of `ReactDOM.findDOMNode` HOT 2
- [React 19] react-test-renderer deprecation HOT 2
- E-Commerce HOT 1
- [React 19] HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.