Git Product home page Git Product logo

Comments (6)

tboba avatar tboba commented on April 28, 2024 1

Hi @ManiTWIndia, we will be releasing a new version of react-native-screens today (or tomorrow), so I believe beta won't be needed for now! 😄
The release will include fixes with incorrect target of touchables, so this issue should be resolved after updating screens to 3.30.0 version (or higher ones).

from react-native.

satya164 avatar satya164 commented on April 28, 2024 1

Do you know if we somehow need to bump screens version to make this issue fixed? I know that screens are defined as a peer dependency in stack, but maybe defining it also as the dev dependency impacts that "contract"?

Nope, only the version installed and linked into the project can impact it.

from react-native.

cortinico avatar cortinico commented on April 28, 2024

@ManiTWIndia Thanks for reporting this.
I believe the issue here is that you're using react-native-screens under the hood which is affected by this bug:
#36710

Can you try again on 0.74 + do a patch-package of react-native-screens

software-mansion/react-native-screens#2028

and report back if the issue is fixed?

from react-native.

ManiTWIndia avatar ManiTWIndia commented on April 28, 2024

Hi @cortinico I am facing some issues in using patch-package of react-native-screens. There are lot of commits after the last release version. Can we get a beta release of react-native-screens to test it out in local?
Thanks

from react-native.

ManiTWIndia avatar ManiTWIndia commented on April 28, 2024

@tboba @cortinico With and without header, its still showing the same pY value. I have updated and using the latest packages in the project. I have pushed the changes. Can you please check in the repo to reverify the issue?
Thanks

WithoutHeader
WithHeader

FYI, I am running the project with RN 0.73.6
When running with RN 0.74, facing below issue when running ios

CompileC /Users/manikanda.s/Library/Developer/Xcode/DerivedData/popoverIssueNew-cmchexkcvzazmngmguhjojjurspp/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-safe-area-context.build/Objects-normal/arm64/RNCSafeAreaViewShadowNode.o /Users/manikanda.s/Desktop/TWMarch/popoverIssueNew/node_modules/react-native-safe-area-context/common/cpp/react/renderer/components/safeareacontext/RNCSafeAreaViewShadowNode.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-safe-area-context' from project 'Pods')

from react-native.

tboba avatar tboba commented on April 28, 2024

@ManiTWIndia Yeah, I can reproduce that on your example. However, after changing the navigator from stack to native-stack, the button has correct target!
image

I'm curious why this bug still occurs on JS stack, maybe because it still uses ~3.20.0 as the dev dependency of stack?
cc @satya164 Do you know if we somehow need to bump screens version to make this issue fixed? I know that screens are defined as a peer dependency in stack, but maybe defining it also as the dev dependency impacts that "contract"?

from react-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.