Git Product home page Git Product logo

Comments (3)

arthaud avatar arthaud commented on May 27, 2024

Hi @cyounkins, thanks for the report.
I have been looking a bit into this.

I think that's because the pyre python client calls the pyre OCaml binary, and that one writes its logs to stdout, and then they go through multiple hops in the client: ocaml binary stderr -> log file -> tail -F -> pyre client stderr (i.e your terminal). My guess is that when we get the final result from the ocaml binary, the logs do not reach the final logger before we stop logging.
This happens around: https://github.com/facebook/pyre-check/blob/main/client/commands/analyze.py#L350-L361
Adding a time.sleep(1) there seems to fix the problem, but it is obviously less than ideal.
I think we need to increase the refresh rate of tail (using option -s), but that isn't available on MacOS, only on Linux. So we might have to implement our own tail function in Python (we discussed this before).

I have a fix internally, I will need to run more tests on it and go through code review.

from pyre-check.

cyounkins avatar cyounkins commented on May 27, 2024

So you were able to reproduce it then?

The reader could wait for a sentinel string. Or you could tail it yourself in python.

from pyre-check.

arthaud avatar arthaud commented on May 27, 2024

Yes I'm able to reproduce and I have a fix doing the tail in python. Please hold on while it goes through code review internally.

from pyre-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.