Comments (3)
Hi @cyounkins, thanks for the report.
I have been looking a bit into this.
I think that's because the pyre python client calls the pyre OCaml binary, and that one writes its logs to stdout, and then they go through multiple hops in the client: ocaml binary stderr -> log file -> tail -F -> pyre client stderr (i.e your terminal). My guess is that when we get the final result from the ocaml binary, the logs do not reach the final logger before we stop logging.
This happens around: https://github.com/facebook/pyre-check/blob/main/client/commands/analyze.py#L350-L361
Adding a time.sleep(1)
there seems to fix the problem, but it is obviously less than ideal.
I think we need to increase the refresh rate of tail
(using option -s
), but that isn't available on MacOS, only on Linux. So we might have to implement our own tail
function in Python (we discussed this before).
I have a fix internally, I will need to run more tests on it and go through code review.
from pyre-check.
So you were able to reproduce it then?
The reader could wait for a sentinel string. Or you could tail it yourself in python.
from pyre-check.
Yes I'm able to reproduce and I have a fix doing the tail in python. Please hold on while it goes through code review internally.
from pyre-check.
Related Issues (20)
- Context Manager - Taint Propagation Issue HOT 6
- PySpark - Incompatible parameter type & Unsupported operand HOT 1
- [Pyre setup.sh] Terminal closes while building from source HOT 2
- Pysa tutorial not working HOT 4
- Find lambdas are not checked correctly HOT 1
- Errors with recursive type aliases: "JSON is declared to have type `TypeAlias` but is used as type `UnionType`"
- pyre from PyPI can't find its typeshed directory HOT 1
- Update pyre-check.org/play to use Python 3.11 HOT 2
- [BUG] Check command exited with non-zero return code: 126. HOT 1
- CI builds are broken
- Pyre / Pysa unable to analyse files with same name in different folders HOT 2
- Taint config on "Running Pysa" page is invalid HOT 1
- Unable to get SQLAlchemy sinks to work HOT 4
- Pyre failing in python 3.8 and 3.9 due to new syntax HOT 9
- How to resolve importing a function from a module with same name HOT 6
- `input` is not part of the environment, no module `input` in search path. HOT 2
- Cannot resolve type for pymysql HOT 2
- Pyre command hangs on on torch.ao.ns.fx.mappings.get_node_type_to_io_type_map HOT 1
- [pysa] Add a high level API for step logging
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyre-check.