ServerIdleSessionConroller:getIdleSession() returns session already in thread about proxygen HOT 5 CLOSED

Are you calling SessionPool::getTransaction first? It should track all the idle sessions in the current thread and give one to you before you go to the ServerIdleSessionController.

https://github.com/facebook/proxygen/blob/main/proxygen/lib/http/connpool/SessionPool.cpp#L101

from proxygen.

Yes always

from proxygen.

I am seeing this connection error in mass after some time fwiw, which may just be a symptom of the leaking. I can confirm that attachThreadLocals() isn't getting called (while detach must be getting called)

AsyncSocketException: failed to create socket (peer=<uninitialized address>, local=<uninitialized address>), type = Internal error, errno = 97 (Address family not supported by protocol)

from proxygen.

So I can confirm HTTPUpstreamSession::AttachThreadLocals() is being called, but nothing after it is being logged. I am doing a local build to see if AttachThreadLocals() is perhaps silently failing

from proxygen.

It seems to be failing on the codec_.forEach(filterFn)

Is it improper to pass nullptr to filterFn?

from proxygen.