Git Product home page Git Product logo

Comments (6)

dominikj111 avatar dominikj111 commented on June 2, 2024 1

So on the end the problem was in the tsconfig.json file.

This is what I had:

{
  "include": ["src/**/*", "tests/**/*"],
  "compilerOptions": {
    "target": "esnext",
    "module": "esnext",
    "moduleResolution": "nodenext",
    "allowSyntheticDefaultImports": true,
    "alwaysStrict": true,
    "noImplicitAny": false,
    "noImplicitThis": false,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "resolveJsonModule": true,
    "allowJs": true,
    "checkJs": true,
    "lib": ["ESNext", "DOM", "ESNext.String"],
    "jsx": "react",
    "baseUrl": "."
  }
}

And I was missing "esModuleInterop": true, :)

from prop-types.

ljharb avatar ljharb commented on June 2, 2024

Do you have NODE_ENV set to production, perhaps? If so, that would break most test runs.

That said, I'm not sure why you're mocking it out, nor what "issue" you mean.

from prop-types.

dominikj111 avatar dominikj111 commented on June 2, 2024

NODE_ENV=development didn't change anything.
That mock file I placed above allowed to pass the tests, but I see plenty warnings in the command line. I'll try to explain better.

I'm running my specific test file by npm test -- -i ./tests/DataFilter/DataFilter.test.jsx
Suddenly my test start failing with this message

TypeError: Cannot read properties of undefined (reading 'string')

      21 |
      22 | ControlHeader.propTypes = {
    > 23 |      title: PropTypes.string,
         |                       ^
      24 |      helpSlug: PropTypes.string,
      25 |      showLoader: PropTypes.bool,
      26 | };

The "prop-types" is installed and I'm able to build and run my React application fine. When I did console.log(PropTypes) below the imports where import PropTypes from "prop-types" is mentioned, I got undefined in the cli.

All other own and third party imports work as expected except the "prop-types". Jest stopped recognizing this import. So I thought that mock of the import may help.

But because your message looks like that this is weird and yet unrecognized behavior, it would be better to make an example app :).

from prop-types.

ljharb avatar ljharb commented on June 2, 2024

Yes, a repro app would be most helpful. Either way, this package hasn't changed in awhile, so it's almost certainly something to do with jest or your jest config.

from prop-types.

dominikj111 avatar dominikj111 commented on June 2, 2024

I have minimal repository to reproduce this issue dominikj111/issue-minimal-proptypes-jest

The npm test will fail, but I realized that after rename the component ControlHeader.tsx to ControlHeader.jsx problem disappear. I don't know why yet.

from prop-types.

ljharb avatar ljharb commented on June 2, 2024

aha, indeed - without esModuleInterop and allowSyntheticDefaultImports, TS's module system is fundamentally broken.

from prop-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.