Comments (5)
Oh, I see you committed a patch yesterday: 435f87c
Thanks! Will test soon.
from it-cpe.
Looks like changing ManagedBookmarks from :multi_string
to :string
prevents the error. However, bookmarks are not getting created properly. Here's some notes from me trying to debug why:
- The ManagedBookmarks key can accept a few different formats (see https://www.chromium.org/administrators/complex-policies-on-windows). I'm assuming the desired output would be a single JSON string value for the ManagedBookmarks key.
- When multiple bookmarks are defined, separately indexed keys are getting created - one for each bookmark - due to the
if data_has_mulitple_entries?
logic into_chef_reg_provider
. Assuming the desired output is a single JSON string, this logic should be modified to exclude ManagedBookmarks (as well as any other potential keys that require JSON strings for values). - The
registry_key
resource call incpe_chrome_win.rb
uses the full path for the key, e.g.HKLM\\Software\\Policies\\Google\\Chrome\\ManagedBookmarks
. This additional folder/subkey is not required and should be at the root (HKLM\\Software\\Policies\\Google\\Chrome
). Changing theregistry_key
resource to usesetting.path
instead ofsetting.fullpath
solves this but may break other keys. The reference registry file linked in the source should be reviewed again to match the hierarchy (https://dl.google.com/dl/edgedl/chrome/policy/policy_templates.zip) - Unsurprisingly, using Ruby hash rockets syntax in the value of the ManagedBookmarks key results in an invalid JSON string, so bookmarks don't get created. The bookmarks do get created after changing the hash rockets to colons/proper JSON.
I will try to start a PR to address some of these things, but would appreciate some feedback on the above so I know that I'm taking the right approach.
from it-cpe.
Thanks for the bug report. I have a patch internally for this specific setting that should be up shortly.
from it-cpe.
Thanks @svmastersamurai, let me know how I can help with a PR.
from it-cpe.
Works great! Thanks for the patch.
from it-cpe.
Related Issues (20)
- cpe_remote should be able to force install expired packages HOT 3
- cpe_chrome fails on Windows in exciting ways HOT 5
- cpe_nomad is still using fb_launchd HOT 3
- where is quickstart.json? HOT 1
- cpe_chrome is broken on chef 16 HOT 10
- Create a migration path from the old chef code to the new chef code HOT 2
- Chef 16.2 breaking changes and consistency in cookbooks HOT 8
- cpe_remote ruby warning in Chef 16.2.73 HOT 2
- add ChoiceChanges.xml support for cpe_remote_pkg HOT 2
- Change return on cpe_munki_locals Resource HOT 4
- Enablement of `unified_mode` for v17+ Chef client compatibility
- cpe_chrome does not require dependency on fb_osquery HOT 5
- `rescue StandardError` in fb_helpers HOT 1
- Native Chef Helpers functions duplicated as node methods HOT 5
- Sevenzip artifact HOT 1
- Curtail usage of Windows 'Administrators', favor SID instead HOT 3
- quickstart.json fails due to missing cpe_adobe_flash
- quickstart in readme does not work.
- mirrorlist..centos.org api is now deprecated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from it-cpe.