OSX Build MemoryMapping.cpp MEMORY_ANONYMOUS about folly HOT 7 CLOSED

Can you send a PR for what you need?

from folly.

Upon closer look, this won't work on HEAD. I am working on getting it to build cleanly on OSX but the recent dependency on linux/futex.h in detail/Futex.h is making it a little more time consuming than I can handle at the moment. see: #50

I'll try to submit one big OSX compat PR when ready.

from folly.

@yfilali thanks! Keep us posted when you get it.

/cc @danslo who is also working on getting it working on OSX

from folly.

@ptarjan Already fixed it: #67

Haven't looked at building folly independently though, only in the context of HHVM. And we do remove quite a bit in that build.

from folly.

@danslo thanks on the #67 pointer.

Unrelated to the specific MAP_ANON issue, Any thoughts about doing the same for a standalone build on OSX? i.e. simply removing components that don't make sense on other platforms? A lot of the components are pretty platform independent from what I can tell (json, fbstring, endian, hash, etc.).

For example ${FOLLY_DIR}/detail/Futex.cpp is removed from hhvm build which skips the linux/futex.h include issue.

from folly.

Yeah, I have no immediate plans to do that, sorry :-( Because they use different build systems it's also not very easy to port those exclusions over. I'll help out where needed, but my primary focus is on HHVM at the moment.

from folly.

No worries, I am looking at a Makefile.am that already has HAVE_LINUX and !HAVE_LINUX sections. It's probably not as hard as I originally though. The exclusions you pointed me towards are a good start.

from folly.