How should I run folly on riscv64? about folly HOT 4 CLOSED

@luhenry Since you added the initial support, do you have any ideas here?

from folly.

I passed the -DFOLLY_HAVE_INT128_T=1 option in cmake, I wonder if that makes sense and if there are any other define to be needed? It just seems to compile successfully.

from folly.

It depends if you're building folly as part of your cmake build or if you're using it as an installed dependency.

In case you're building folly as part of your cmake build, you can add a set(FOLLY_HAVE_INT128_T 1) before doing your FetchContent_MakeAvailable. See https://github.com/facebookincubator/velox/blob/main/CMake/resolve_dependency_modules/folly/CMakeLists.txt#L46 for example.

And in case you're using an installed folly (via find_package for example), then you would need to do add_compile_definitions(FOLLY_HAVE_INT128_T=1) as you've suggested.

from folly.

It depends if you're building folly as part of your cmake build or if you're using it as an installed dependency.

In case you're building folly as part of your cmake build, you can add a set(FOLLY_HAVE_INT128_T 1) before doing your FetchContent_MakeAvailable. See https://github.com/facebookincubator/velox/blob/main/CMake/resolve_dependency_modules/folly/CMakeLists.txt#L46 for example.

And in case you're using an installed folly (via find_package for example), then you would need to do add_compile_definitions(FOLLY_HAVE_INT128_T=1) as you've suggested.

Got it. Thank you.

from folly.