Comments (4)
kayhadrin
commented on June 14, 2024
Thanks for submitting this bug report.
I think we indeed should also use `invariant()` in prod too, but I'm not in
a position to test this anymore since leaving the company. So for
simplicity, this error scenario should be probably just logged.
I don't remember why `argument` being `null` or `undefined` are treated
differently right now though. Personally, I'd rather see `undefined`
resolved as the string "undefined" rather than an empty string because it
makes the issue easier to spot.
For the `bt()` call with a *missing* param, this error case should have
been detected during the string extraction phase I reckon; but it's good
that the runtime js code still verifies that arguments are provided
properly.
Can I ask in which circumstances you detected this issue?
Regards,
David
…On Tue, Apr 9, 2024, 14:41 Christoph Nakazawa ***@***.***> wrote:
🐛 Bug Report
This block of code
<https://github.com/facebook/fbt/blob/dd54f9ecb78c7a72ed9e9c42867ab3c2da08852f/runtime/shared/substituteTokens.js#L100-L120>
has two bugs:
1. invariant in a __DEV__ block which changes execution flow depending
on whether fbt is running in the dev or prod environment. This violates
Facebook's engineering principles from 2011-2021. RIP.
2. In production, missing params will be replaced with undefined in
strings because of the argument === null check. This check should be argument
== null instead.
To Reproduce
- Create an fbt string like fbt('Test string with {missing}
substitution'). In dev, this code will throw an error. In prod, it
will replace {missing} with "undefined".
Expected behavior
- Either throw both in dev and prod if there is a param mismatch, or
throw in neither places.
- Do not substitute missing params with undefined.
—
Reply to this email directly, view it on GitHub
<#412>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMS5EBC7LA4OZ3D5NATFDY4N5QXAVCNFSM6AAAAABF54ZN5WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTENRUGIZDOMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from fbt.
cpojer
commented on June 14, 2024
Admittedly, I have a funky use-case here:
- I have user-generated input that is extracted from the db and translated.
- Users may change the initial text which may or may not provide the same params as before.
- I have custom params that end up using the same token delimiters (
{and}) because otherwise it doesn't work well with my translation provider (crowdin). Those params are substituted from the translated string with user-generated data separately from fbt.
With all of these constraints combined, I had a try-catch around my fbt calls for user-generated text, since the invariant would crash the game rather than falling back to the non-translated input. I then realized that the invariant was skipped and undefined was inserted. I worked around by patching fbt, which works great for me.
Here is a real scenario I can imagine happening many times at Facebook:
- Dev amends code before landing without trying it. Reviewer approves without trying it.
- Code is actually wrong, but doesn't throw in prod because the invariant is dev only.
- Code now renders "undefined" in place of the param in a user-facing string in prod.
from fbt.
cpojer
commented on June 14, 2024
Fixed by @voideanvalue in bd91582 and f409115.
from fbt.
kayhadrin
commented on June 14, 2024
@voideanvalue
Awesome, thanks for the fix!
…On Wed, Apr 17, 2024, 10:08 Christoph Nakazawa ***@***.***> wrote:
Closed #412 <#412> as completed.
—
Reply to this email directly, view it on GitHub
<#412 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMS5BJ3EDMJS5MZDXQTS3Y5XDSFAVCNFSM6AAAAABF54ZN5WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGQ4TQOJZGEYDGOI>
.
You are receiving this because you commented.Message ID:
***@***.***>
from fbt.
Related Issues (20)
- Provide simple debug mode HOT 5
- No published version of babel-plugin-fbt since 0.13.0-beta HOT 2
- Remove fbjs dependency HOT 2
- Feature: publish eslint rules to help promote better Fbt API usage practices HOT 1
- Fix Support for Shared Enum Typescript/ES6 Import/export syntax with Babel 7 HOT 3
- Can't install FBT with npm HOT 1
- node-fetch vulnerability transitive from isomorphic-fetch HOT 3
- Unable to install react-native-fbt in expo SDK 45 bare workflow #33797 HOT 7
- Bug: unable to extract `intlList`
- Vite support HOT 1
- React 18 support
- unexpected pluralization behavior
- RTC-Folly outdated with lastest react native version (0.70.1) HOT 2
- Ols
- react-native-fbt not working on lastest React Native version (0.70.6) HOT 3
- Make `fbt` work with other compilers like SWC HOT 2
- New release? HOT 2
- fbt.plural manifest is wrong in --react-native-mode
- Copyright and footer logo needs to be updated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fbt.