Comments (4)
@gaearon , if I understood your concerns correctly, the frustrating part is that code like the following will become more difficult to maintain with the increased number of commands in later versions.
var relativePath = isInNodeModules ? '../../..' : '..';
if (process.argv[2] === '--debug-template') {
relativePath = '../template';
}
If so, with match-js or a similar approach, I should be able to refactor the code similar to the following, though not exactly in your proposed form
relativePath = match( env )(
CASE(REPO, ...),
CASE(DEPENDENCY, ...),
CASE(EJECTED, ...),
CASE(otherwise, ...)
);
where env
could be process.argv
or other value that represents the execution environment.
Currently, I see that --debug-template
and --smoke-test
are both set at process.argv[2]
, and there is no check for EJECTED
because scripts/eject.js
is the only involved script.
To help me understand your problem correctly, could you, from a user's perspective, list some test commands that set flag(s)?
In my forked repo, I will test my ideas. I hope that we can move towards a solution that you wanted.
Cheers
from create-react-app.
These flags are all internal and we don’t want to expose this code for the user. They are only useful for testing and local development of create-react-app
itself. So if
statements are not a problem and we don’t need to refactor them. What we need is a way to cut some code after eject
ing.
from create-react-app.
@gaearon ,
The above change deletes dead code on eject
ing; However, this does not prevent users from using npm start --debug-template
before react-scripts
is eject
ed. At lease, we don't expose the flag to general users.
I will think if we could hide the flag and cut off the code on the time of building react-scripts
.
If you think the current progress is OK, I will do some tests and create a PR.
from create-react-app.
This was in #257.
from create-react-app.
Related Issues (20)
- 不动 啊 HOT 1
- React Application Embedded Script HOT 1
- Allow user to config publicPath of webpack and set its default value to auto
- Cannot find module 'ajv/dist/compile/codegen' HOT 2
- I am so angry i just cant take it HOT 2
- An Error HOT 1
- Bad Resource link in https://create-react-app.dev/ HOT 2
- About deprecated packages HOT 1
- Is there a good fork of CRA? HOT 1
- Broken and soon to be discontiued short links (goo.gl)
- Create react app
- vscode inspection , please look at here
- npm error code ENOENT npm error syscall lstat npm error path C:\Users\ADMIN\AppData\Roaming\npm npm error errno -4058 npm error enoent ENOENT: no such file or directory, lstat 'C:\Users\ADMIN\AppData\Roaming\npm' npm error enoent This is related to npm not being able to find a file. npm error enoent npm error A complete log of this run can be found in: C:\Users\ADMIN\AppData\Local\npm-cache\_logs\2024-08-29T14_54_53_598Z-debug-0.log HOT 1
- eslint config should enable "react/jsx-key"
- BSA App
- Create-react-app should create a jsconfig.json file by default
- Reels
- Program1 HOT 1
- Nothing but error messages HOT 1
- Vulnerability Issues with postcss and nth-check in react-scripts Dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-react-app.