Git Product home page Git Product logo

Comments (18)

f avatar f commented on May 14, 2024 1

What about vue-wait?

from vue-wait.

f avatar f commented on May 14, 2024 1

I asked npm if they can give me the name vuel and they did. I published the repo with vuel name, but I also liked vue-wait. On the other hand, vuel sounds more brand-ish.

I'm not sure but for next major version, maybe we can rename it too. Or maybe renaming a project twice is not a really good idea :)

However, we now have vuel name.

from vue-wait.

f avatar f commented on May 14, 2024 1

VueWait -> Vuel
$wait -> $vuel

For isWaiting or isLoading what about just is since we already using $vuel prefix?

$vuel.is("creating users") sounds legit to me.

from vue-wait.

sky-code avatar sky-code commented on May 14, 2024

vue-loading sounds good for me

from vue-wait.

f avatar f commented on May 14, 2024

It's occupied on npm.

from vue-wait.

sky-code avatar sky-code commented on May 14, 2024

vuel as have made vuex or to leave a project name as is if there is no option better

from vue-wait.

f avatar f commented on May 14, 2024

I decided not to change it for now, if a brilliant idea comes, we can think about it. Also, renaming would cause some problems in future.

from vue-wait.

sky-code avatar sky-code commented on May 14, 2024

vuel more brand-ish and more fancier (hipster) name, i don't think renaming project twice is a problem if renaming has occurred within a week.
But what to do with other names?
rename VueWait to ?
rename $wait to ?
isWaiting become isLoading ?

from vue-wait.

f avatar f commented on May 14, 2024

And we should think about slot name waiting. I think we should only rename VueWait to Vuel and let's leave rest as is.

from vue-wait.

sky-code avatar sky-code commented on May 14, 2024

@f agree.
slot waiting can be renamed to loading
also method is need some more explicit name

from vue-wait.

f avatar f commented on May 14, 2024

What about is to waits.

$vuel.waits('creating user') => Boolean
$vuel.waits('cart.*') => Boolean

In view isLoading or isWaiting feels so long to me. I feel like I write isLoading everywhere and code becomes too ugly. I'm trying to make it shorter. And as you said is also too short and implicit.

I wish we can use ? as method name just like in Ruby so we could use waits?('create.*).

from vue-wait.

f avatar f commented on May 14, 2024

This is the latest API proposal, let's discuss on it:

$vuel.start('creating user') # Starts a loader
$vuel.end('creating user') # Ends a loader
$vuel.waits('creating user') # Individual loading exists
$vuel.any # Any loading exists

# Template
<vuel for='creating user'>
  <template slot='loading'>Loading...</template>
</vuel>

# Mappers
...mapVuelGetters({...})
...mapVuelActions('module', {...})
Current Keyword Proposal
$wait $vuel
start start
end end
is waits
any any
wait (store name) vuel
<v-wait> <vuel>
for="" for=""
slot="waiting" slot="loading"
mapWaitingGetters mapVuelGetters
mapWaitingActions mapVuelActions

Please share your own proposals.

from vue-wait.

sky-code avatar sky-code commented on May 14, 2024
  • is- isActive
  • any - anyActive

maybe slot="loading" - slot="active" for consistency
not sure <vuel> is a good name (no prefix)

from vue-wait.

f avatar f commented on May 14, 2024

Maybe @Koc also can share his opinions about it.

from vue-wait.

sky-code avatar sky-code commented on May 14, 2024

or without is prefix

  • is- active
  • any - activeAny - or change semantic to check any if no args passed and remove this method

from vue-wait.

f avatar f commented on May 14, 2024

Yep this is better. Removing things feel me better :)

What about <vuel>? What about <vuel-wait for="creating users">? Since wait for doing something is a legit English sentence, <vuel-wait for="creating users"> sounds good to me.

<vuel-wait for="creating user">
  <template slot="active">Creating user, please wait...</template>
  User created.
</vuel-wait>

from vue-wait.

f avatar f commented on May 14, 2024

If we make <vuel-wait> or <vuel-X>, we should make slot name consistent to X.

<vuel-wait for="creating user">
  <template slot="waiting">Creating user, please wait...</template>
  User created.
</vuel-wait>

from vue-wait.

Koc avatar Koc commented on May 14, 2024

I'm prefer leave $wait is it possible and rename is to waiting: $wait.waiting('product')

from vue-wait.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.