Help me understand max_phrase_length about fist HOT 2 CLOSED

Hey @WardCunningham thank you for the issue. I am really glad that you mentioned this. You did not miss anything. That number should be moved to a config file, which it will in a future version. The choice of 10 words was arbitrary.

It is expected that you can index a document longer than 10 words. The max_phrase_length as you correctly named it is just that, the max length of a phrase that is indexed. So how you are expecting it to work is the way it works. It can take a document of variable size and index all phrases in that document up to 10 words long. This number if probably big for most use cases as you have pointed out and it will be configurable in the future.

Dump and load does not require the max phrase length because those functions are simply serializing and deserializing the hashmap. So the hashmap is already built when dump and load are called.

from fist.

Closing this issue due to inactivity. Hopefully this answered your question.

from fist.