Comments (5)
Yay. I'll look into it.
from trade-dangerous.
So, the problem is, the plugin doesn't remove no longer existing items from the DB. I just hadn't implemented it.
I /think/ I have a solution, but I haven't tested it yet and I don't really have the time to do so right now.
I'm uploading it to the dev branch now, in case you want to test it. I'll push it to main once we know for sure it works.
from trade-dangerous.
Other than that odd one I found, it's likely somewhat difficult to find test cases (or we would have found this before).
Is it reasonable to add "bogus" commodities to a given station by adding fake, but valid lines to the DB and then see if the plugin removes it?
from trade-dangerous.
Do an update, remove some entries from one or more of the stations in the source file and save it. Do a second update with the force option, see if the entries you removed from the source file are gone in the DB.
The code I added, assuming no bugs or unintended results, does the following:
Set current station to -1, create empty dict.
For each item in the source file:
Check if current station matches item's station. (Will be false for the first item.)
If not, delete all items in the current dict set to false, delete the dict, set current station to the new station, and create a dict of all the possible items set to false
If so, set the current item to true in the dict.
from trade-dangerous.
Fixed in 8a43404
from trade-dangerous.
Related Issues (20)
- Executing a trade run after a database update gives an error. In my TD\data folder the Tradedangerous.prices file is not showing HOT 6
- Fix the need to generate prices - pretty please with sugar on top. HOT 16
- When I run the command "trade.py import -P eddblink -O all", I get error messages ! HOT 9
- A General List of Potential Issues
- Fix warnings in deploy HOT 4
- Server hosting upgrade HOT 53
- Locale changes break on systems with certain locales, in general unnecessary
- Looks like `--progress` no longer works HOT 1
- Function/command "Cmdr Profile" generates an error HOT 4
- The search for specific goods generates an error ! Function "buy" HOT 10
- Again a problem with the command/function "Cmdr Profile" HOT 5
- The Culling: What's deprecated/discontinued?
- Enable Discussions tab in Github?
- PadSize argument parser is explicitly only allowing one character HOT 3
- Duplicate Rescue Ship "HR 1183/Arc's Faith" HOT 1
- The server seems to be no longer updating. HOT 11
- Could you add option to filter out Fleet Carriers HOT 1
- `trade.py trade` definitely does more work than it should HOT 7
- SQL error on first re-import of `eddblink` HOT 2
- Database / needed file size optimisations HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trade-dangerous.