sync req.session.save function does not write response about session HOT 9 CLOSED

Do you know what could cause this?

No. Many people have upgraded and you're the first to report an issue.

Is there now a different middleware ordering required because of that or is the patch not correct?

I can't say. You need to provide code I can run to see the issue so I can diagnose it and see what the issue is. The code should not require external databases and should include a note for how I reproduce the issue with the code.

from session.

I can't say. You need to provide code I can run to see the issue so I can diagnose it and see what the issue is. The code should not require external databases and should include a note for how I reproduce the issue with the code.

Ok yeah I'll try that soon.
First I'm trying to check what exactly causes this to happen. I've broken it down to the end.call calls which are not calling with the chunk and encoding parameters.

//Edit: more specifically: it seems to boil down (currently) to this line: 7077190#diff-168726dbe96b3ce427e7fedce31bb0bcR207
When replacing this line with end.call(res, chunk, encoding) it works.

//Edit2: With the default memory Store it works, might be that the connect-session-file store has an issue with this new code.

from session.

nevermind, it seems it's an issue with the connect-session-file, e.g. if setting useAsync there to true it works. Bit weird, will have to check it out or switch to a more updated file store.

from session.

nevermind, it seems it's an issue with the connect-session-file, e.g. if setting useAsync there to true it works. Bit weird, will have to check it out or switch to a more updated file store.

OK, I understand the issue now. req.session.save should be an async function (i.e. the line after it should be called before the body is called), but it looks like the store you are using calls it sync instead, which makes the end before the write below it. I can work-around this for people's stores that are basically broken.

from session.

should be an async function (i.e. the line after it should be called before the body is called), but it looks like the store you are using calls it sync instead, which makes the end before the write below it.

Hmm ok I understand. Pardon my probably false assumption, but couldn't it be that, even though the store might be using an async function, the end is called before the write (i.e. depending on the scheduling which is being done).

from session.

the end is called before the write (i.e. depending on the scheduling which is being done).

no. it would only occur when save is called sync, nothing else.

from session.

@mweibel if you want, try out the fix for your issue with npm install expressjs/session#1.6.x

from session.

Works, thanks!

from session.

Thank you very much for the confirmation. This has been published as version 1.6.4 and express 3.13.0 will automatically pick up this new version for you.

from session.