generating new sessions with an asynchronous store about session HOT 6 CLOSED

You store.generate function must be sync. You are not supposed to actually create the session in the store at that time. You should be waiting for the store.set call to create the entry in your storage system.

from session.

if other middleware layers (eg, authentication/authorization) are expecting the session to exist in the datastore.

They should only access the session using req.session; perhaps we can add some kind of option to allow for saving the session to the store up-front, like you are wanting.

from session.

The store implementation doesn't actually define generate, only set. So the store I'm using has properly set up an async set, but because of how generate gets called, it doesn't matter.

And now that i've dived into the code, I realize that it should only be using req.session, as you say, which is probably totally reasonable, but it was a pretty big gotcha before I figured it out!

So maybe a feature request, maybe just a call out in the docs would do.

from session.

The store implementation doesn't actually define generate, only set.

Correct, but you made it sound like you were over-writing this, so I assumed you were redefining it. Apparently not, so yes, it doesn't even get save to the database until the request that created the session has completed.

from session.

@japherwocky - is this still an issue for you? are you good with @dougwilson 's explanation to your concerns?

from session.

Sorry, this was so long ago, I have no idea if it's an issue for that project anymore. Feel free to close the issue!

from session.