.maxAge for the session store about session HOT 9 CLOSED

I think this exists?

https://github.com/expressjs/session/blob/master/session/session.js#L42-L52
#2

from session.

I think that only applies to the cookie; the ticket is about applying a max age to the store itself.

from session.

I have added maxAge and other convenient methods to Store... a pr will be available soon....
Giving a maxAge to the session store allows to expire the data without expire the cookie and vice versa.
In my opinion if the cookie expires also the store should expire... what do you think?

from session.

In my opinion if the cookie expires also the store should expire... what do you think?

That does not work for session-length cookies, since the cookie cannot have an expiration to have it automatically expire when the user closes their browser. The store still needs to be able to expire, though.

from session.

Sorry, you're right, for "expired cookie" i was meaning "needs to be destroyed".

from session.

This seems like a store specific feature. For example, a mongodb store lib could use mongo's "TTL" collection feature. Is this ticket suggesting we implement this feature for the memory store?

from session.

Yes, this would be for memory store

from session.

I have been looking at this for a bit now. There seems to be an attempt to do this here, but I don't think this will ever work. Because the only way the session is destroyed is if the cookie sent from the client has expired, but the cookie won't be sent if its expired, right?!? I wrote a test to explain what I'm seeing.

A solution for this would be to setup the MemoryStore to check itself for expired sessions. That seems like overkill to me, but I don't know how else this could be implemented.

from session.

Lets just not bother until we remove memstore entirely in favour of some sort of cookie-store for default.

from session.