Git Product home page Git Product logo

Comments (22)

jonathanong avatar jonathanong commented on May 5, 2024

Totally. I just made this ASAP. iirc all those names are taken for logger. If anyone can think of better names for any module, feel free to change.

from morgan.

defunctzombie avatar defunctzombie commented on May 5, 2024

Naming is hard.
On Mar 15, 2014 4:47 PM, "Jonathan Ong" [email protected] wrote:

Totally. I just made this ASAP. iirc all those names are taken for logger.
If anyone can think of better names for any module, feel free to change.

Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-37737586
.

from morgan.

tj avatar tj commented on May 5, 2024

It would be easy if npm wasn't a global namespace :( at this rate it's better to just use expressjs/logger and bitch until npm gets proper GH semver support

from morgan.

jonathanong avatar jonathanong commented on May 5, 2024

i also prefer NOT using express- namespace because then people might think that they have to use express to use the middleware, when in fact most middleware can be used as fn(req, res, next) without express

from morgan.

tj avatar tj commented on May 5, 2024

Yea that's true, but having really obscure names is worse IMO, apps just become non-sensical with a ton of really meaningless names

from morgan.

graphicsxp avatar graphicsxp commented on May 5, 2024

I totally agree. The new name is confusing and does not tell us anything about the actual module's purpose. Why is it not simply called logger ??

from morgan.

dougwilson avatar dougwilson commented on May 5, 2024

@graphicsxp logger is already taken on npm.

from morgan.

graphicsxp avatar graphicsxp commented on May 5, 2024

then just add a prefix :) But morgan is clearly not intuitive.

from morgan.

defunctzombie avatar defunctzombie commented on May 5, 2024

Just use the search feature on npm. Who cares. Once you know what the
module is you remember. If you want another logging module use that.
Express itself is not called "http-server-framework", it is called express
which tells you nothing about what it does. You just know what it does by
learning it.

Yes, in a perfect world maybe we could have had express-logger but we don't
and there is nothing special about our logger vs some other logger someone
makes.
On Mar 31, 2014 9:42 AM, "graphicsxp" [email protected] wrote:

then just add a prefix :) But morgan is clearly not intuitive.

Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-39089145
.

from morgan.

graphicsxp avatar graphicsxp commented on May 5, 2024

@defunctzombie if it appeared in the search results when searching for 'logger', then I would agree that the name does not really matter. But go ahead and search for 'logger', morgan is nowhere to be found. That's because no keywords were assigned to the package.

from morgan.

tj avatar tj commented on May 5, 2024

I think it's confusing still personally, I've read code with tons of substacky names and you really have no fucking clue what's going on

from morgan.

defunctzombie avatar defunctzombie commented on May 5, 2024

I tend to just do var logger = require('morgan'); in the examples that use the logger. If someone suggests a better name then we will consider it. I think we have beat the issue dead. We all agree a better name is in order, but no one is proposing one we can actually use :)

from morgan.

Fishrock123 avatar Fishrock123 commented on May 5, 2024

Given that express-logger was last updated 3 years ago, I see no reason not to attempt to re-claim the package name.

https://www.npmjs.org/package/express-logger

Anyone want to shoot him an email?

Also see: https://www.npmjs.org/doc/disputes.html

EDIT:

i also prefer NOT using express- namespace because then people might think that they have to use express to use the middleware

Right, missed that.

EDIT 2: My new idea of Exlogger is unclaimed.

from morgan.

sahat avatar sahat commented on May 5, 2024

@visionmedia was it your idea to separate off connect middleware from express?

Instead of just express in package.json, I now have this mess, in addition to 39 other NPM modules:

    "express": "^4.0.0",
    "body-parser": "^1.0.1",
    "cookie-parser": "^1.0.1",
    "static-favicon": "^1.0.2",
    "express-session": "^1.0.2",
    "morgan": "^1.0.0",
    "csurf": "^1.1.0",
    "compression": "^1.0.1",
    "errorhandler": "^1.0.0",

And what's with the naming inconsistency? errorhandler and method-override. Also csurf should be just called called csrf, static-favicon should be just called favicon. If naming was the problem then it should have been prefixed with express-, to have clean and consistent names: express-logger, express-csrf, express-body-parser. It's easier to explain to people that you can also use them for non-Express apps, than to have these weird and obscure names..

Anyway, I am just extremely disappointed with this entire Express 4.0 middleware separation business. Perhaps less things to maintain in Express framework, but more work for end-users now.

from morgan.

Fishrock123 avatar Fishrock123 commented on May 5, 2024

@sahat It's life that some npm module names are already taken.

That, and since the middleware technically works for native node (without express), we'd rather not prefix it all with some express- thing.

from morgan.

defunctzombie avatar defunctzombie commented on May 5, 2024

Enough complaining about this issue. I am closing it. No one has proposed anything of value (aka a name we can actually use on npm).

from morgan.

Fishrock123 avatar Fishrock123 commented on May 5, 2024

... exlogger is still not taken.

from morgan.

dougwilson avatar dougwilson commented on May 5, 2024

I have come to like morgan, just as I get by with winston, express, koa, gulp, grunt, underscore, lodash, and I can go on forever on "meaningless" names in node.js packages that are popular.

from morgan.

jonathanong avatar jonathanong commented on May 5, 2024

exlogger sounds a logging utility that is no longer a logging utility

from morgan.

tj avatar tj commented on May 5, 2024

I don't mind when modules with a "creative" aspect have weird names, but when they're effectively just commodity modules it gets old/confusing quick, it'll only get worse with npm

from morgan.

matejkramny avatar matejkramny commented on May 5, 2024

.. so, we need a new npm. that'll solve all these issues

from morgan.

pille72 avatar pille72 commented on May 5, 2024

Named after Dexter, a show you should not watch until completion.

Of course you should watch it, just don't let some1 spoiler you ;-)

from morgan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.