Server examples should not respond to notification messages about jsonrpcserver HOT 3 CLOSED

Hi John, the server does respond to notifications in certain circumstances. For example if the request is not valid json, it can't be parsed, it's impossible to know if the request is a notification or not, so it will respond with an error.

What's the response you're getting?

from jsonrpcserver.

My point is that when a valid notification is received, the server sends a response, which it should NOT do. So, for example, your websockets example

async def main(websocket, path):
    request = await websocket.recv()
    response = await methods.dispatch(request)
    await websocket.send(str(response))

Should be modified to something like this:

async def main(websocket, path):
    request = await websocket.recv()
    response = await methods.dispatch(request)
    // Only respond if NOT a notification request
    if not isinstance(response, jsonrpcserver.response.NotificationResponse):
        await websocket.send(str(response))

(error handling logic not shown),

Responding to any notification request is inconsistent with the jsonrpc standard.

from jsonrpcserver.

Thanks for reporting.

from jsonrpcserver.