Git Product home page Git Product logo

Comments (5)

patduin avatar patduin commented on May 23, 2024

@pradeepbhadani the issue says "regexp" but you're ok with just * wild cards correct?

from waggle-dance.

pradeepbhadani avatar pradeepbhadani commented on May 23, 2024

@patduin No. I am suggesting to have regex and * wildcard.
I will update the acceptance criteria. My bad, I should have made * wildcard explicit.

from waggle-dance.

patduin avatar patduin commented on May 23, 2024

Can we stick to one, e.g. or we allow the db name to be a regex or we allow wildcards but not both will just make it a bit easier to implement and result would be the same

from waggle-dance.

courtsVII avatar courtsVII commented on May 23, 2024

Regex will complicate the configuration significantly, I think we should stick to just wildcard, for example if we support regexes there will be clashes all over the place, say user whitelists a db called db and there are databases of the name mydb dbone etc etc there will be unexpected matches, they will have to specify patterns rather than simple strings

from waggle-dance.

patduin avatar patduin commented on May 23, 2024

we need to do full matches not partial matches.
We're going for regexp I'll update the issue

from waggle-dance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.