Just thoughts... about instrumentedsql HOT 4 CLOSED

for pq, I put in a PR with them: lib/pq#585

Indeed, while the code copied from stdlib is minimal, there is indeed some, I see little alternative but keeping up with changes .. it's only really maybe 20-30 lines of code, so I'm comfortable with that

tracing/logging fit quite well with the paradigm I picked, the main reason I'd like a custom hook is for people to hook in metrics, seeing as not everyone will want the same metrics, a hook would be ideal for it.

from instrumentedsql.

I'd be curious to see your code, is there anything you'd like to merge into this codebase you're doing differently perhaps ?

from instrumentedsql.

No, I've got nothing interesting yet. My code is essentially the same as yours, but only works with pq (because I only chose to implement and forward the interfaces I know pq implements). Your stuff is definitely just mine+better. But I think I'm going to take a crack are rewriting it following the httptrace pattern of just hooks, which can be composed. Then you can layer in logging, tracing, metrics, etc.

from instrumentedsql.

Nods Sounds cool! Good luck

from instrumentedsql.