Comments (6)
@devurandom You can reopen if you can reproduce same issue on broken exfat later.
from exfatprogs.
Is it possible that this:
Lines 64 to 66 in 7c3b617
always sets repair = false
for problems which have a "no" default, like the cluster problems:
Lines 39 to 43 in 7c3b617
?
From a user point of view I could imagine it to work like this:
bool ask_repair(struct exfat *exfat, struct exfat_repair_problem *pr) {
if (!(exfat->options & FSCK_OPTS_REPAIR_ALL)) {
return false;
}
bool repair = false;
bool have_choice = false;
if (exfat->options & FSCK_OPTS_REPAIR_AUTO) {
if (pr->flags & ERF_DEFAULT_YES) {
repair = true;
have_choice = true;
} else if (pr->flags & ERF_DEFAULT_NO) {
repair = false;
have_choice = true;
}
} else if (exfat->options & FSCK_OPTS_REPAIR_YES) {
repair = true;
have_choice = true;
} else if (exfat->options & FSCK_OPTS_REPAIR_NO) {
repair = false;
have_choice = true;
}
if (!have_choice) {
// ask user
}
return repair;
}
from exfatprogs.
The current version can repair only checksum corruptions, and refuse fixing the other corruptions with "n".
from exfatprogs.
Please try to run fsck.exfat on #exfat-next branch.
git clone --branch=exfat-next https://github.com/exfatprogs/exfatprogs
from exfatprogs.
I currently do not have a broken exFAT partition to test this with.
from exfatprogs.
Okay...
from exfatprogs.
Related Issues (20)
- [tools][feature request] Allow To Change Volume Serial Number ("ID") HOT 6
- [feature request] File system usage reporting HOT 13
- Can't recover corrupted boot region with 1.1.0 HOT 2
- Detach this fork from old upstream
- Unknown entry type 0xaa HOT 1
- Invalid boot checksum after formatting an Advanced Format 4K native HDD HOT 4
- dump.exfat should do more than just disk/volume information HOT 5
- fsck:fix double free of exfat pointer HOT 2
- fsck: fix Out-of-Bounds Accesses in function bytes_to_human_readable HOT 8
- Full format without --full-format ? HOT 4
- Exfatprogs Release Signing Key has expired HOT 2
- exfat-fs fails with a Windows-formatted drive HOT 15
- kernel 3.10.14 is not useful! HOT 3
- Not access to folders HOT 11
- tune.exfat breaks the FS in some cases HOT 9
- pagefile.sys file on exfat partition shows up as 0 bytes HOT 16
- exfat driver documentation missing
- Coverity check - improper use of negative value HOT 9
- mkfs: Documenting default for --boundary-align and --cluster-size HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exfatprogs.