dominoes: ask for Chain rather than CanChain OR modify README to ask for CanChain about csharp HOT 10 CLOSED

@robkeim How do you feel about this?

from csharp.

summary of what I say in exercism/fsharp#296 is that I think doing Chain

advantages:

• student peace of mind that their code found a correct chain

disadvantage

• more complex test
• students are probably already finding a full chain anyway, so it's not like using Chain is going to "weed out" any more students.

from csharp.

I added my $0.02 in: exercism/fsharp#296

from csharp.

Re-opened.

from csharp.

@petertseng and @ErikSchierboom I'm going to go ahead and close this issue since the canonical data has canChain and not chain:
https://github.com/exercism/problem-specifications/blob/master/exercises/dominoes/canonical-data.json

If we want to re-open this for discussion I think we should change the canonical data first then update the individual tracks. Does that make sense?

from csharp.

the canonical data has canChain and not chain

My suggestion for chain stands even when the canonical data contains canChain because https://github.com/exercism/problem-specifications/blob/master/exercises/dominoes/canonical-data.json#L21-L24.

It does not matter to me whether this issue is closed, but what does matter to me is that if it is closed, it is closed for the right reason.

If considering chain in canonical-data.json, it may be possible if the canonical data chooses a canonical representation for the chain that is invariant to reversal and rotation. A question I have not explored is whether there is only one chain under this canonicalisation.

from csharp.

I think I lean towards keeping this closed, to keep the implementation of an already challenging problem slightly simpler.

from csharp.

It looks like this track will need to change its README.

The https://github.com/exercism/csharp/blob/master/exercises/dominoes/README.md says such things like:

Compute a way to order a given set of dominoes

Since this track asks for canChain, this should probably read "Compute whether there exists a way to order a given set of dominoes"

For example given the stones 21, 23 and 13 you should compute something like 12 23 31 or 32 21 13 or 13 32 21

Since this track asks for canChain, this should probably read "For example given the stones 21, 23 and 13 you should declare that there exists a possible chain (for example, 12 23 31 is a possible chain)"

Note upcoming changes to domino text representation in exercism/problem-specifications#972

from csharp.

Good point @petertseng... I'm re-opening this issue to track a README change.

from csharp.

I'm working on this

from csharp.