Git Product home page Git Product logo

Comments (11)

ijaureguialzo avatar ijaureguialzo commented on July 17, 2024 1

The release version is working perfectly.

Thanks!

from sphinx-copybutton.

choldgraf avatar choldgraf commented on July 17, 2024

huh, that is super weird. Do you have a live site somewhere online?

from sphinx-copybutton.

ijaureguialzo avatar ijaureguialzo commented on July 17, 2024

Hello, you can see it live here:

https://lm-xml-apuntes.readthedocs.io/es/copybutton_test/apuntes/20_sintaxis_xml.html

The source which is used for the build is in this repository, on it's own copybutton_test branch:

https://github.com/Egibide-DAM/lm-xml-apuntes/tree/copybutton_test

from sphinx-copybutton.

choldgraf avatar choldgraf commented on July 17, 2024

great - thanks for the link, I'll try and figure this one out this week! If you come up with a solution of your own, please don't hesitate to share and we can incorporate it into the extension!

from sphinx-copybutton.

choldgraf avatar choldgraf commented on July 17, 2024

hey - I think that this should be fixed in #16...can you try installing sphinx_copybutton from master and seeing if that fixes things? You might still need to tweak some CSS but the green weirdness should be gone...

from sphinx-copybutton.

ijaureguialzo avatar ijaureguialzo commented on July 17, 2024

Great, thank you!

It's working correctly now, no green background and the icon looks good:

https://lm-xml-apuntes.readthedocs.io/es/copybutton_test/apuntes/20_sintaxis_xml.html#

BTW: I'm new to this thing of pip extensions and don't know how are they released; how do I now when it's released in production and can stop using the direct reference to the GitHub branch?

from sphinx-copybutton.

choldgraf avatar choldgraf commented on July 17, 2024

you'd need to update whenever sphinx-copybutton cuts a new release.......which I'll do now, so you can start using the non-github version in about 5 minutes :-)

from sphinx-copybutton.

choldgraf avatar choldgraf commented on July 17, 2024

ok, should be released - give it a shot and see if that works!

from sphinx-copybutton.

wtbarnes avatar wtbarnes commented on July 17, 2024

I'm using the latest PyPI release (v0.2.5) with the RTD theme and I'm still seeing this behavior. The icon is small, but without the green box. Any chance this problem has crept back in?

from sphinx-copybutton.

ijaureguialzo avatar ijaureguialzo commented on July 17, 2024

The icon seems good, only a bit small.

I customized my css and added a 1.4em width and height to the link and now it looks much better. Maybe this could be opened as a PR to be included in the main css file.

Here's the source (changes are in last commit): https://github.com/egibide-dam/lm-xml-apuntes

And the generated docs where the button is used: https://lm-xml-apuntes.readthedocs.io/apuntes/20_sintaxis_xml.html

Hope it helps.

from sphinx-copybutton.

choldgraf avatar choldgraf commented on July 17, 2024

if folks think there's a fix that could be made in this repo that is more consistent across themes etc, let me know and I'm happy to review PRs!

from sphinx-copybutton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.