Add comments to queries about pyexasol HOT 5 CLOSED

Yep, it should be easy to implement using import_params and export_params.

Do you prefer to have comment in the beginning, at the end or somewhere in the middle of query? :)

from pyexasol.

beginning is fine :)

So, for import, you'd recommend adding a key to import_params and use it here: https://github.com/badoo/pyexasol/blob/da486a18313d3cd4b40280ade66f5f21b0c2f120/pyexasol/http_transport.py#L161

for export, use the same idea here: https://github.com/badoo/pyexasol/blob/da486a18313d3cd4b40280ade66f5f21b0c2f120/pyexasol/http_transport.py#L105

And add a bit of documentation here: https://github.com/badoo/pyexasol/blob/da486a18313d3cd4b40280ade66f5f21b0c2f120/docs/HTTP_TRANSPORT.md#parameters

Would that be sufficient?

from pyexasol.

1. Extra argument comment for export_params, import_params.
2. Additional condition in query builders for EXPORT and IMPORT to use the extra argument.
3. Validation, to make sure comment will not contain \n, */ or other ways for SQL injection.
4. Documentation.
5. A few lines in http_transport examples.

Thank you.

from pyexasol.

Live in 0.16.1. Enjoy! :)

from pyexasol.

That was fast! thanks :)

from pyexasol.