Comments (4)
Thanks. There is a choice of tests with summary_factorlist
that can be specified. So it kind of depends what the user wants to do. Are you utilising the various column and row summarising arguments? Let me know if anything is not clear in the documentation and I can adjust.
from finalfit.
Thanks Serdar.
As you know, we have kept all tables as data frames or tibbles in finalfit to be as flexible as possible in output. The question would be how to do that and stay so flexible (one of the benefits of finalfit in my humble opinion!). finalfit(..., metrics = TRUE)
has a second data frame with model information and the two are returned as a list. But even this creates an extra step for users separating them.
Interested in your thoughts.
from finalfit.
Hi Ewen,
I continue to try to add some functions to jamovi as a module. While working on crosstables I wanted to compare some similar packages. I added tangram, arsenal, gtsummary and finalfit. Then I realised that the p-values are different. See below images.
tangram:
(is currently under update in with recent commit p-values are gone, probably will be fixed soon)
The problem is that users are ready to accept these results as publication ready and I wanted to add the test names. I think the packages use different tests and I tried to dig into codes. tangram (as default and text), arsenal as an argument, and gtsummary as an optional function gives the names of functions. I could not add arsenal's test names due to html output structure (mayoverse/arsenal#298).
- For the
metrics = TRUE
I tried to add it to multivariate survival function, the output is skewed, but it can be worked on.
-
If the output is a list and I can extract them as result[["table"]] and results[["footnote"]] it will be easy to implement.
-
Or, to keep dataframe output, you may consider adding another column for test names and include it optional argument similar to
p = TRUE
something liketestname = TRUE
. This way you may get rid of pasting asteriks, symbols or numbers to p-value. And with another function footnote can be generated via combining variable name and testname from dataframe output.
Thank you for your time.
from finalfit.
Then I can add the arguments as options to the user interface and depending on the selected one I can add test names and I can add a link to the documentation
cont = "mean", cont_nonpara = NULL, p_cont_para = "aov", p_cat = "chisq"
Thank you :) I will let you know the updates.
from finalfit.
Related Issues (20)
- finalfit does not show median, only mean HOT 1
- inverse OR in finalfit in R continuation closed event
- Fine-gray model visualization HOT 2
- Extending cont_cut to or_plot HOT 1
- Adjust axes for coef plots? HOT 1
- Multinomial Logistic Regression HOT 4
- About modifying the hr_plot function HOT 3
- Error with or_plot HOT 2
- `fct_explicit_na()` was deprecated in forcats 1.0.0 HOT 1
- missing_compare - discrepancy in the manual (Kruskal-Wallis) HOT 1
- `Namespace in Imports field not imported from: ‘tidyselect’` HOT 1
- The output from the stratified models example does not align with the results of the stratified Cox model. HOT 4
- Table format of the finalfit output only gives HTML format script HOT 4
- Potential bugs finalfit command HOT 1
- Finalfit package: Descriptive statistics query for p values and getting Median as statistics HOT 1
- p>0.05, but 95% confidence interval for the odds ratio DOES NOT include 1. How can I check and standardise the methods used to calculate the p-values and confidence intervals? HOT 2
- ff_remove_ref for summaryfactorlist HOT 4
- finalfit results in table with "Coefficient" instead of "OR" HOT 3
- ff_plot with interaction HOT 2
- Feature Request: Random effect in univariable models HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from finalfit.