Git Product home page Git Product logo

Comments (4)

ewenharrison avatar ewenharrison commented on July 29, 2024 1

Thanks. There is a choice of tests with summary_factorlist that can be specified. So it kind of depends what the user wants to do. Are you utilising the various column and row summarising arguments? Let me know if anything is not clear in the documentation and I can adjust.

from finalfit.

ewenharrison avatar ewenharrison commented on July 29, 2024

Thanks Serdar.
As you know, we have kept all tables as data frames or tibbles in finalfit to be as flexible as possible in output. The question would be how to do that and stay so flexible (one of the benefits of finalfit in my humble opinion!). finalfit(..., metrics = TRUE) has a second data frame with model information and the two are returned as a list. But even this creates an extra step for users separating them.
Interested in your thoughts.

from finalfit.

sbalci avatar sbalci commented on July 29, 2024

Hi Ewen,

I continue to try to add some functions to jamovi as a module. While working on crosstables I wanted to compare some similar packages. I added tangram, arsenal, gtsummary and finalfit. Then I realised that the p-values are different. See below images.

FinalFit:
finalfit

gtsummary:
gtsummary

tangram:
(is currently under update in with recent commit p-values are gone, probably will be fixed soon)
tangram

arsenal:
arsenal

The problem is that users are ready to accept these results as publication ready and I wanted to add the test names. I think the packages use different tests and I tried to dig into codes. tangram (as default and text), arsenal as an argument, and gtsummary as an optional function gives the names of functions. I could not add arsenal's test names due to html output structure (mayoverse/arsenal#298).

  • For the metrics = TRUE I tried to add it to multivariate survival function, the output is skewed, but it can be worked on.

Ekran Resmi 2020-06-19 17 29 21

  • If the output is a list and I can extract them as result[["table"]] and results[["footnote"]] it will be easy to implement.

  • Or, to keep dataframe output, you may consider adding another column for test names and include it optional argument similar to p = TRUE something like testname = TRUE. This way you may get rid of pasting asteriks, symbols or numbers to p-value. And with another function footnote can be generated via combining variable name and testname from dataframe output.

Thank you for your time.

from finalfit.

sbalci avatar sbalci commented on July 29, 2024

Then I can add the arguments as options to the user interface and depending on the selected one I can add test names and I can add a link to the documentation

cont = "mean", cont_nonpara = NULL, p_cont_para = "aov", p_cat = "chisq"

Thank you :) I will let you know the updates.

from finalfit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.