Inheritance not working? about ajax-solr HOT 5 CLOSED

Code needs to be:

Child.__super__.foo.call(this);

Also, the Child's constructor won't call the Parent's constructor. You need to use __super__ if you want that.

from ajax-solr.

Thank you for clarifying. I got off on the inheritance trail because of something I observed with ParameterHashStore earlier this week, but your suggestion works and so does ParameterHashStore when I now test it in isolation, so I'll take another look at my code.

from ajax-solr.

So, funny story, the first thing I did in response to your suggestion was hop over to ParameterHashStore and add a call to the super constructor. ...Then I played with my example for a while and forgot I had changed ParameterHashStore when I went back to test it in isolation. In fact, without the explicit call, it does fail for the following example:

var Manager = new AjaxSolr.Manager({
    solrUrl: 'http://evolvingweb.ca/solr/reuters/'
});
Manager.setStore(new AjaxSolr.ParameterHashStore());
Manager.init();

An error occurs in ParameterHashStore.init on the expression "exposed.length" because exposed is undefined.

Sorry for the confusion, but unless I'm again missing something about the usage, it looks like ParameterHashStore needs to call the super constructor. Other classes (possibly ParameterYUIStore?) may have the same problem.

from ajax-solr.

Ah, good catch! I've pushed a fix. Let me know if it works now.

from ajax-solr.

Much better, thanks!

from ajax-solr.