Git Product home page Git Product logo

Comments (6)

PEMapModder avatar PEMapModder commented on August 22, 2024

Using PlayerMoveEvent isn't the main problem. The problem is that you are unnecessarily querying whether a player is registered, while that can be cached (at least for this session) in PlayerMoveEvent.

from serverauth.

Flavius12 avatar Flavius12 commented on August 22, 2024

Yes, you're right! Authenticated users are stored in an array in memory. Accessing it only, instead of doing also Disk I/O or database queries is 99% faster. Then, registration check in each event is useless because if the user is authenticated automatically it's also registered

from serverauth.

Flavius12 avatar Flavius12 commented on August 22, 2024

@legoboy0215 About the PlayerMoveEvent why should I make a task instead of using PlayerMoveEvent?

from serverauth.

legoboy0215 avatar legoboy0215 commented on August 22, 2024

Check PM forums. @PEMapModder wrote a detailed post about this, with performance concerns. I'll try to make a PR, but I haven't got time yet :)

from serverauth.

PEMapModder avatar PEMapModder commented on August 22, 2024

@legoboy0215 I wrote that when you asked which one was better, and you might not be running the handler per tick. But the difference isn't really that big in this case ;)

from serverauth.

Flavius12 avatar Flavius12 commented on August 22, 2024

Fixed in v2.12

from serverauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.