Git Product home page Git Product logo

Comments (7)

EvilFreelancer avatar EvilFreelancer commented on May 30, 2024

Hello! Thanks for your report. Which version of library you use?
I've asked, because in 1.1 was added ->equal() method to Query class, especial for things with = symbol.
> and < symbols i'll check soon, probably here is the bug.

from routeros-api-php.

sashkov avatar sashkov commented on May 30, 2024

I use composer, as I see it has installed the version 1.1.1 (my project use php 7.1.33, laravel 5.8). Here:

>composer show evilfreelancer/routeros-api-php
name     : evilfreelancer/routeros-api-php
descrip. : Modern Mikrotik RouterOS API PHP7 client for your applications
keywords : PSR-4, mikrotik, routeros, socket-client
versions : * 1.1.1
type     : library
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
source   : [git] https://github.com/EvilFreelancer/routeros-api-php.git 31736bc231ac399450d086363999f363488d71f0
dist     : [zip] https://api.github.com/repos/EvilFreelancer/routeros-api-php/zipball/31736bc231ac399450d086363999f363488d71f0 31736bc231ac399450d086363999f363488d71f0
path     : C:\php\eclipse-workspace\laravel\vendor\evilfreelancer\routeros-api-php
names    : evilfreelancer/routeros-api-php

autoload
psr-4
RouterOS\ => ./src/

requires
ext-sockets *
php ^7.1

requires (dev)
phpunit/phpunit ^7.0

yes, I use ->equal() for =, thank you, very usefull.
OK, I didn't know that I use old version of your library.
I will test my test environment with last version.
Thank you for answer and advice to check version (because I thought composer installed last version).

from routeros-api-php.

sashkov avatar sashkov commented on May 30, 2024

I've updated the library to 1.2.1 and still getting such situation.
I debugged in Query.php function where with all three params (key,value,operator) and noticed next.
In line 90 ? concats with key ('?' . $key) and after that there is a call a private function world.
In fnc world in line 132 operator concats with key ($operator . $key).
Here the key is ?reply-src-address and the operator is >.
After concat key is >?reply-src-address, but should be ?>reply-src-address.
What do you think about it?
Sorry if I'm wrong.

from routeros-api-php.

EvilFreelancer avatar EvilFreelancer commented on May 30, 2024

Hello! I've checked this issue, and can suggest solution, you may try to use '?key' as key name, instead ['key', '?'] combination. Soon i've add another method (eg. "->more()") for this.

from routeros-api-php.

EvilFreelancer avatar EvilFreelancer commented on May 30, 2024

And sorry for long response, I was on vacation and after i've back was a hard week of work :)

from routeros-api-php.

sashkov avatar sashkov commented on May 30, 2024

Hello! Thank you for this suggestion.
Right, it would be completely comportable with methods like "->more()".
It is your project, so it is obvious that you take your time for your work as much as you need :)
My production project is working with your current library, so I'll close this question.

from routeros-api-php.

EvilFreelancer avatar EvilFreelancer commented on May 30, 2024

Not only mine, many made their contribution, I've just started it :)

If you have the opportunity, you also can implement the necessary functionality, this is done very simply, just see how the where and equal methods work, then suggest the "pull request". It will speed up the implementation process.

from routeros-api-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.