login() always return true regardless of legacy about routeros-api-php HOT 12 CLOSED

Here is a more complete proposition :

        // if :
        //  - we have more than one response
        //  - response is '!done'
        // => problem with legacy version, swap it and retry
        // Only tested with ROS pre 6.43, will test with post 6.43 => this could make legacy parameter obsolete ?
        if (count($response)>1 && $response[0] === '!done' && !$this->config('legacy'))
        {
            $this->_config->set('legacy', true);
            return $this->login();
        }
        // Return true if we have only one line from server and this line is !done
        return (1 === count($response)) &&  isset($response[0]) && ($response[0] === '!done');

from routeros-api-php.

@matracine hello! And thank you for this good solution. Maybe you can create Merge Request with your fixes?

from routeros-api-php.

Nice, can you add these few lines to unit tests of Client class?

from routeros-api-php.

Will try, didn't looked your tests, sorry.

from routeros-api-php.

You can use my other project with RouterOS in Docker container for running unit testing on your computer. You just need to have expect, Docker, Docker Compose, next clone the repo and exec docker-compose up -d, then you need preconfigure virtual routers via preconf.tcl script from root of routeros-api-php:

./preconf.tcl 12223
./preconf.tcl 22223

And after this you can run tests:

./vendor/bin/phpunit

from routeros-api-php.

Great, I was looking how to do that, thanks. On the way....

from routeros-api-php.

Almost ready, but I'm not super "pull request aware" ;)
How do I modify my pull request ?
Can you review my branch and tell me if this is OK for you (added test__constructLegacy2() in ClientTest.php.
I did phpunit --html-coverage to verify my code was tested.

from routeros-api-php.

Small update by me, I've added endless loop detection logic.
Thanks for your help @matracine! Now $this library can automaticaly detect legacy firmware and this is awesome.

from routeros-api-php.

Happy if I helped, this is realy a great lib.
Nothing more to do for me ?
Thanks.

from routeros-api-php.

If you want you may help me with other issue #2 it's about queries in loop, sometimes library returned empty array. The second issue is achieving 100% coverage of code (details is here).

By the way, look at new syntax, you can simplify your code little bit.

In any way thank you for help :)

from routeros-api-php.

Oh, I forgot to say, your edits are available in the 0.8.1 version of the library.

from routeros-api-php.

Hello,
Thanks, saw it for 0.8.1, I already updated my projects :)
I will have a look for #2 and code coverage.

Regards,

from routeros-api-php.