Git Product home page Git Product logo

Comments (19)

RandomFractals avatar RandomFractals commented on September 26, 2024 1

Create New Project in selected Folder with the default Evidence template project cloning below. I don't think this can be any simpler. We'll see if we should embed template project instead of cloning it from github in a separate ticket.

evidence-new-project-2

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

New Evidence Project command display in the Command Palette...

image

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

New Evidence Project command displayed for the selected folder in the built-in vscode File explorer context menu:

image

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Select new project folder dialog display listing all the folders in an open workspace:

image

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Evidence extension Output view with the start of Create new project logging to trace this process:

image

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Empty folder check, info message, and project folder dialog selection re-redisplay when the previously selected folder has files, or subfolders with files:

image

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Some final notes on this New Evidence Project feature implementation for testing:

  • We don't prompt for the template project github url to clone it for a new Evidence project
  • Users can use the initial Create Project from Template feature to create new projects from their own Evidence app templates on github
  • We don't prompt to install dependencies for the Evidence project created in an open Workspace with other files because we don't support the "nested" Evidence projects and files in an open workspace yet. See our new Limitations section in docs for more info on this. We will update that section prior to v1.1.0 final features release.
  • For the time being, users will need to open created Evidence project folder in a separate VS Code window session, i.e. new workspace for all the other Evidence extension features and enhancements we implemented in the published v1.0.0 and will ship in v1.1.0 to work.

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

The last part is now scripted too in #59, but users need to click Open Folder and ok when folder list is displayed to open newly ceated Evidence project in a new VS Code window. We are using standard VS Code Open Folder command and UI there:

evidence-create-open-project-workflow-2

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Updated New Project Output view logging and display from #58:

image

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Changed selected folder is not empty notification to an error message in #61. This dialog is displayed when you use New Evidence Project command from the Command Palette...:

image

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Creating New Project in an empty VS Code workspace from start to finish:

evidence-new-project-empty-workspace-2

from evidence-vscode.

archiewood avatar archiewood commented on September 26, 2024

Issue with credentials

Repro

  1. Open a new workspace
  2. add a folder that will contain evidence eg reports
  3. right click reports-> Create new Evidence project

Expected behaviour

No credentials are added in root folder

Actual

Credentials are added at the root folder (not inside reports folder).
These probably aren't harmful, but are confusing.
I don't think we need to add any credentials in this circumstance

CleanShot 2023-06-05 at 14 35 18

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

@archiewood what do you mean by credentials? we don't modify any file or folder credentials anywhere in this vscode extension.

Are you referring to the ./evidence folder created at the top level of the open workspace folder?

Looks like I need to copy the settings.json with demo duckdb config to the selected project folder inside an open workspace.

Btw, that was added as a workaround for the missing settings.json in your app template to resolve evidence-dev/evidence#804 in extension code and have a working app template we can use for new project scaffolding.

See: #39

from evidence-vscode.

archiewood avatar archiewood commented on September 26, 2024

Are you referring to the ./evidence folder created at the top level of the open workspace folder?

Yes

In this case it is not used, as it should be inside the child directory

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

See most recent changes in #60 to address that. I will remove my settings.json copy from clone repo code.

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Tagging #65 to track it for v1.1.0 release

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

@archiewood resolved your issue in the commit above. Also, please try creating new project from the built-in template. It's instant:

evidence-project-from-template-3

from evidence-vscode.

archiewood avatar archiewood commented on September 26, 2024

Yep works instantly for me as well. 🔥

Any reason we do not use this for the core "Create Evidence Project from template" command?

from evidence-vscode.

RandomFractals avatar RandomFractals commented on September 26, 2024

Did not get to it 🙂 See #63

Plus I was not sure how well it would work on the Mac and needed you to test it.

We can wrap it up in #63 today.

from evidence-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.