Organizing around the project rather than the markdown file about evidence-vscode HOT 6 CLOSED

I actually tried to get workspaceContains to work in activation, but ran into issues. Will revisit it again this week to fine tune that part.

https://code.visualstudio.com/api/references/activation-events#workspaceContains

from evidence-vscode.

We already perform many Evidence project detection checks and commands enablement.

This was added in (#18)

Current limitation

Mostly due to Sprint 1 only one week of dev constraint to get basic interactive commands working first:

• v1.0.0 only supports Evidence projects at the root/open workspace folder. I mentioned this in slack last week.

We'd need to extend those checks to detect nested Evidence projects for dbt, etc.

from evidence-vscode.

Treatment of status bar items / commands

When an evidence project is detected in the workspace, we should offer all of the commands and status bar items, regardless of what files are open in vscode.

Eventually we might have some commands which are file specific, but right now all of them are project-level.

Enabling and activating vscode extensions on startup is taxing and frowned upon in vscode dev community.

Evidence extension and commands get activated on these main language events in VS Code currently:

  "activationEvents": [
    "onLanguage:emd",
    "onLanguage:markdown",
    "onLanguage:javascript",
    "onLanguage:json",
    "onLanguage:svelte",
...

Opening any of those files in VS Code will activate Evidence extension and reveal available commands.

Also, many extensions contribute to the VS Code status bar. So, us taking space there without any emd documents to preview or update is hard to justify.

from evidence-vscode.

If it's possible to use logic beyond just the file extension to determine how to treat the file, I think we could use the above approach to make a simpler judgements about how to treat the .md files that the extension encounters:

1. All .md files inside project-root/pages can safely be treated as evidence markdown
2. All .md files outside of project-root/pages should be treated as regular markdown

I like this suggestion and will use it when I add the rest as described in #9 for the markdown detection.

from evidence-vscode.

1. Makes sense to defer the monorepo support.
2. Can you activate upon detecting a qualifying package.json in the workspace? I agree that always having the 'evidence run' command present in the status bar would not be desirable, but always having it there while you're in an Evidence project seems like the correct behaviour. Fine to defer it to feedback though.
3. Re: #9, that's fantastic!

from evidence-vscode.

Most of the listed loose ends in this ticket were already resolved. See other referenced tickets.

The rest will be handled in #64 and other markdown related tickets.

from evidence-vscode.